-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
th19: thanm has no mechanism to deal with 2 images having the same name #111
Comments
not the first time zun has done this mistake |
The difference with the .dat file is that you can only index files by file name. The game itself uses file names to load files from the .dat archive. The difference here is the game doesn't need the image file name to make use of the ANM. Therefore, if 2 images in an ANM have the same name, both can, and in the case of front.anm, probably are used. This makes this a much bigger problem than duplicate entires in the .dat file. This really makes me question how these files are even put together in the first place |
more importantly (and unlike th17.dat), the files are different |
this isn't actually the first time
th185
th19
probably earlier games too |
fixed in 58be110 |
Turns out #111 wasn't that much of an issue after all. This is a partial revert of 58be110, in a sense that I reimplemented the stuff that I removed in that commit. Now we have both combined and separate (-u) extraction implemented in a somewhat elegant manner. Every entry now has a link to the next entry of the same name. For separate extraction, we simply don't build the links. Additionally, th19 is now fully supported in the combined mode (except for replacement and for JPEGs). thanm will opportunistically try to avoid recompressing PNGs. The -uu flag creates all the necessary conditions for that.
TH19 seems to be the first game in the Touhou series, that has multiple entries in the same ANM file use the same file name for the image. This causes thtk to overwrite the first file with the next, causing both files to be the same upon recompilation of the ANM file. This doesn't matter for the game itself. The game itself doesn't even use these filenames (I think). But we've grown to rely on them, and it looks like we can no longer do that (at least for th19).
The text was updated successfully, but these errors were encountered: