Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestNG pulls in JUnit, and some tests use a mixture of assertions #20

Open
detouched opened this issue Jun 7, 2018 · 0 comments
Open

TestNG pulls in JUnit, and some tests use a mixture of assertions #20

detouched opened this issue Jun 7, 2018 · 0 comments

Comments

@detouched
Copy link

TestNG version used has JUnit as direct dependencies, and test classes use JUnit's assertions.

This is quite fragile and prevents migration to a newer TestNG library.
detouched added a commit to detouched/diffparser that referenced this issue Jun 7, 2018
@detouched
Parse incomplete line markers, untangle test dependencies (fixes thom…
e85b5a2 
…bergs#17, thombergs#20)

- Incomplete marker lines are not parsed as NEUTRAL lines anymore,
  they are set as a flag on a Diff for either of the diff side instead.
  This is a potentially breaking change, so version bumped to 2.0.
- TestNG used to pull in JUnit as a direct dependency, and test classes
  used to use a mixture of TestNG and JUnit assertions. This commit
  bumps TestNG to a recent 6.14.3 which doesn't have JUnit anymore,
  and adjusts the tests to use TestNG assertions only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@detouched