Skip to content

Commit 253f790

Browse files
adding pro/con solution 2
Signed-off-by: Thomas Poignant <[email protected]>
1 parent 068a9a5 commit 253f790

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

Diff for: website/src/pages/specification/20241027-flagsets.md

+11
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ authorizedKeys:
144144
- It is easy to give ownership of a flag set to a team, by giving them access to the file.
145145
146146
**CON**
147+
- The flag set configuration is at the same place as the flag configuration, so it is possible to edit the flag set name directly inside the file _(risk of overriding another flag set)_.
147148
- If we want the same flag to be part of multiple flag sets, we need to duplicate the flag in multiple files.
148149
149150
### Solution 2: specify the flag set in the retriever configuration
@@ -190,6 +191,16 @@ authorizedKeys:
190191
admin:
191192
- apikey3
192193
```
194+
195+
**PRO**
196+
- It is simple to configure a flag set by putting all the flags at the same place.
197+
- It is easy to understand which flags are part of a flag set.
198+
- It is easy to give ownership of a flag set to a team, by giving them access to the file.
199+
- The flag set name is directly associated to the retriever, so it is not possible to edit it directly inside the file.
200+
201+
**CON**
202+
- If we want the same flag to be part of multiple flag sets, we need to duplicate the flag in multiple files.
203+
193204
### Solution 3
194205
:::note
195206
Feel free to propose other solutions here.

0 commit comments

Comments
 (0)