Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASL stall fix broke arbitrary capability requests #137

Open
A-UNDERSCORE-D opened this issue Jun 26, 2021 · 2 comments
Open

SASL stall fix broke arbitrary capability requests #137

A-UNDERSCORE-D opened this issue Jun 26, 2021 · 2 comments

Comments

@A-UNDERSCORE-D
Copy link

ca8c401 sets the requested capabilities to nil on enter, thus overwriting any and all user requested capabilities.

@fzwoch
Copy link

fzwoch commented Jul 23, 2021

Can confirm. Tested with Twitch's "Tags" capability.

@fzwoch
Copy link

fzwoch commented Feb 8, 2022

That's still true with latest release.

This workaround works for me, but not sure that the correct approach is, or why the flags get reset?

diff --git a/irc.go b/irc.go
index a02b2b7..5e3dc10 100644
--- a/irc.go
+++ b/irc.go
@@ -510,7 +510,6 @@ func (irc *Connection) Connect(server string) error {
 
 // Negotiate IRCv3 capabilities
 func (irc *Connection) negotiateCaps() error {
-       irc.RequestCaps = nil
        irc.AcknowledgedCaps = nil
 
        var negotiationCallbacks []CallbackID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants