Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with 721A contract mint functions #58

Open
0xTING opened this issue Jul 18, 2022 · 2 comments
Open

Bug with 721A contract mint functions #58

0xTING opened this issue Jul 18, 2022 · 2 comments

Comments

@0xTING
Copy link

0xTING commented Jul 18, 2022

I created a new 721A contract on your premade contracts - on Rinkeby
I then go to the embed tab - it says "sold out" - this is because no NFTs have been created and isSoldOut takes priority over no active claim phase according to your logic
So far so good
I then "create" and upload any nft image with dummy meta
I then go to embed and it shows on the mint button (in preview):
"There is not enough supply to claim" if quantity is 1
"Mint (Free)" if quantity is 0

The issue here is that the increase quantity button is not disabled, and the "Mint (free)" button when quantity is 0 is also not disabled. See images
Screenshot 2022-07-18 114310
Screenshot 2022-07-18 114359

I replicated this with your 721 (on rinkeby) and went through your source code to confirm this is incorrect behaviour. The expected behaviour is correct on the 721 as below:
Screenshot 2022-07-18 114516
This should be the case as no claim phase has been created. Both the mint button and the quantity buttons are disabled as expected.

Perhaps the issue lies in calling useClaimIneligibilityReasons

@warengonzaga
Copy link
Member

I can replicate the issue @nachoiacovino kindly check the GIF below.
EoQKFpIAJi

Fresh new Signature drop contract without any claim phases.

@kien-ngo
Copy link

kien-ngo commented Jul 5, 2023

I think I can tackle this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants