Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap - Header banner bugs / improvements #1337

Open
3 of 5 tasks
FayCross opened this issue Oct 18, 2024 · 0 comments
Open
3 of 5 tasks

Bootstrap - Header banner bugs / improvements #1337

FayCross opened this issue Oct 18, 2024 · 0 comments
Labels
Accessibility Bootstrap template bug enhancement

Comments

@FayCross
Copy link
Collaborator

FayCross commented Oct 18, 2024 •
edited
Loading

I've been doing some accessibility testing and have found a few issues (accessibility & otherwise) with the BS banner heading functionality. Some of them are already listed in #1129 but I will close that and list current issues here as there is a lot of discussion of things that are fixed in that issue.

  • Scroll down hint & arrow doesn't do anything when clicked - the pointer cursor that you see on hover suggests that it should. Perhaps change so it auto-scrolls down on click.
  • Scroll down hint & arrow doesn't reappear if you scroll down and then scroll back up.
  • If a fixed heading height is set, it can be too small to show all of the heading text - this should be considered a minimum height instead.
  • Tabbing / keyboard only access becomes tricky with a full screen banner - you can get stuck in a loop and unable to get down to main content (see 1st page of release notes for an example)
  • When collapse banner is off and you scroll down, the section menu first appears below the banner but then jumps up to overlap it as you scroll further down.
@FayCross FayCross mentioned this issue Oct 18, 2024
Closed
FayCross added a commit that referenced this issue Nov 7, 2024
@FayCross
Various accessibility improvements in Bootstrap template:
f1c115f 
- Fix tabbing issues when full screen banner is used, make scroll down hint & arrow clickable to auto scroll, ensure scroll down text and arrow reappears if you scroll back up #1337
- Fix #1345 bug where object tag on main page (e.g. PDFs) messed up keyboard focus on lightboxes
- Fix #1346 allow lightbox close buttons to be translatable
- Fix #1352 (multiple issues):
 - Stop empty sections being added to section menu if section has no name
 - improve sub section links accessibility
 - allow translation of aria-labels used to mark up page / section / subsection navigation areas
 - fix skip link bug where it didn't always target correct section
 - use aria-live to announce page name on page change
 - allow screen reader access to glossary tooltips
 - improve accessibility of search
 - improve accessibility of access code blocks
torinfo pushed a commit that referenced this issue Nov 7, 2024
@FayCross @torinfo
Various accessibility improvements in Bootstrap template:
3be0a4c 
- Fix tabbing issues when full screen banner is used, make scroll down hint & arrow clickable to auto scroll, ensure scroll down text and arrow reappears if you scroll back up #1337
- Fix #1345 bug where object tag on main page (e.g. PDFs) messed up keyboard focus on lightboxes
- Fix #1346 allow lightbox close buttons to be translatable
- Fix #1352 (multiple issues):
 - Stop empty sections being added to section menu if section has no name
 - improve sub section links accessibility
 - allow translation of aria-labels used to mark up page / section / subsection navigation areas
 - fix skip link bug where it didn't always target correct section
 - use aria-live to announce page name on page change
 - allow screen reader access to glossary tooltips
 - improve accessibility of search
 - improve accessibility of access code blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility Bootstrap template bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FayCross