Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new install set to apache=true creates incorrect .htaccess #1324

Open
ronm123 opened this issue Oct 3, 2024 · 2 comments
Open

new install set to apache=true creates incorrect .htaccess #1324

ronm123 opened this issue Oct 3, 2024 · 2 comments

Comments

@ronm123
Copy link
Collaborator

ronm123 commented Oct 3, 2024

I've noticed this before but can't remember if I've mentioned it via email or already added it as an issue but I can't find the issue if I did.

When trying to complete a new install today and setting apache to true during the final install step it seems the .htaccess automatcially created picks up the /setup/ directory. so you send up with lines like ^edit_([A-Za-z0-9]+)$ /setup/edit.php?template_id=$1 instead of just ^edit_([A-Za-z0-9]+)$ /edit.php?template_id=$1 and then the rewrite rules obviously don't work correctly.

@torinfo have you had this happen? It's an easy fix to find and replace '/setup' with nothing to remove but obviously ideally /setup shouldn't be part of the rules in the first place.

@torinfo
Copy link
Collaborator

torinfo commented Oct 4, 2024

No, I have not noticed this, but I never use apache=true.

But I have a suspicion what happens, and I'll fix it. I would be very surprised if this has ever worked correctly if you choose this during setup.

@ronm123
Copy link
Collaborator Author

ronm123 commented Oct 4, 2024

TBH I've usually got a new install up and running and then manually put a htaccess in place and then set Apache to true.
But ist should obviously work correctly - and you should use it! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants