Skip to content

Commit 70aff4c

Browse files
author
Jussi Kukkonen
committed
tests: Improve verify_signature tests
Test unknown signature algorithm/scheme. Also shorten the incorrect (but syntactically valid) signature a bit. Signed-off-by: Jussi Kukkonen <[email protected]>
1 parent 743c440 commit 70aff4c

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

tests/test_api.py

+8-1
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,13 @@ def test_sign_verify(self):
205205
with self.assertRaises(exceptions.UnsignedMetadataError):
206206
targets_key.verify_signature(metadata_obj)
207207

208+
# Test failure on unknown scheme (securesystemslib UnsupportedAlgorithmError)
209+
scheme = timestamp_key.scheme
210+
timestamp_key.scheme = "foo"
211+
with self.assertRaises(exceptions.UnsignedMetadataError):
212+
timestamp_key.verify_signature(metadata_obj)
213+
timestamp_key.scheme = scheme
214+
208215
# Test failure on broken public key data (securesystemslib CryptoError)
209216
public = timestamp_key.keyval["public"]
210217
timestamp_key.keyval["public"] = "ffff"
@@ -220,7 +227,7 @@ def test_sign_verify(self):
220227
timestamp_key.verify_signature(metadata_obj)
221228

222229
# Test failure with valid but incorrect signature
223-
sig.signature = "52af76354db3403242e1437b1fbf1c7edc4e66b81dfd63b3026ff681d57e88e11a697cca78061a376a9dd8d7fde5777b14d4e6d8e75f976101cbc61321642f06"
230+
sig.signature = "ff"*64
224231
with self.assertRaises(exceptions.UnsignedMetadataError):
225232
timestamp_key.verify_signature(metadata_obj)
226233
sig.signature = correct_sig

0 commit comments

Comments
 (0)