fix(test): add article creation in latestArticles tests for accurate ID checks

Author: gitwoz

Diff for: src/connectors/__test__/articleService.test.ts

@@ -568,21 +568,36 @@ describe('latestArticles', () => {
       value: articleChannelThreshold,
     })
 
+    // create articles
+    const [article1] = await articleService.createArticle({
+      title: 'test',
+      content: '',
+      authorId: '1',
+    })
+    const [article2] = await articleService.createArticle({
+      title: 'test2',
+      content: '',
+      authorId: '1',
+    })
+    const [article3] = await articleService.createArticle({
+      title: 'test3',
+      content: '',
+      authorId: '1',
+    })
+
     // create channels
     const channel = await channelService.updateOrCreateChannel({
       name: 'test',
       description: 'test',
       providerId: 'test-latest',
       enabled: true,
     })
-
     const channel2 = await channelService.updateOrCreateChannel({
       name: 'test2',
       description: 'test2',
       providerId: 'test-latest2',
       enabled: true,
     })
-
     const channel3 = await channelService.updateOrCreateChannel({
       name: 'test3',
       description: 'test3',
@@ -594,7 +609,7 @@ describe('latestArticles', () => {
     await atomService.create({
       table: 'article_channel',
       data: {
-        articleId: '1',
+        articleId: article1.id,
         channelId: channel.id,
         score: articleChannelThreshold + 0.1,
         enabled: true,
@@ -603,7 +618,7 @@ describe('latestArticles', () => {
     await atomService.create({
       table: 'article_channel',
       data: {
-        articleId: '1',
+        articleId: article2.id,
         channelId: channel2.id, // disabled channel
         score: articleChannelThreshold + 0.1,
         enabled: true,
@@ -613,7 +628,7 @@ describe('latestArticles', () => {
     await atomService.create({
       table: 'article_channel',
       data: {
-        articleId: '2',
+        articleId: article3.id,
         channelId: channel2.id, // disabled channel
         score: articleChannelThreshold + 0.1,
         enabled: true,
@@ -623,7 +638,7 @@ describe('latestArticles', () => {
     await atomService.create({
       table: 'article_channel',
       data: {
-        articleId: '3',
+        articleId: article3.id,
         channelId: channel3.id,
         score: articleChannelThreshold + 0.1,
         enabled: false, // disabled article channel
@@ -639,9 +654,9 @@ describe('latestArticles', () => {
       excludeChannelArticles: false,
     })
     expect(articles.length).toBe(3)
-    expect(articles.map(({ id }) => id)).toContain('1')
-    expect(articles.map(({ id }) => id)).toContain('2')
-    expect(articles.map(({ id }) => id)).toContain('3')
+    expect(articles.map(({ id }) => id)).toContain(article1.id)
+    expect(articles.map(({ id }) => id)).toContain(article2.id)
+    expect(articles.map(({ id }) => id)).toContain(article3.id)
     const [articlesExcludedChannel, totalCount2] =
       await articleService.latestArticles({
         maxTake: 500,
@@ -651,10 +666,12 @@ describe('latestArticles', () => {
         excludeSpam: false,
         excludeChannelArticles: true,
       })
-    expect(articlesExcludedChannel.length).toBe(1)
-    expect(articlesExcludedChannel.map(({ id }) => id)).not.toContain('1')
-    expect(articlesExcludedChannel.map(({ id }) => id)).toContain('2')
-    expect(articlesExcludedChannel.map(({ id }) => id)).toContain('3')
+    expect(articlesExcludedChannel.length).toBe(2)
+    expect(articlesExcludedChannel.map(({ id }) => id)).not.toContain(
+      article1.id
+    )
+    expect(articlesExcludedChannel.map(({ id }) => id)).toContain(article2.id)
+    expect(articlesExcludedChannel.map(({ id }) => id)).toContain(article3.id)
     expect(totalCount1).toBe(totalCount2 + 1)
   })
 })