Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config.ts validation #432

Open
emilgoldsmith opened this issue Jul 29, 2018 · 0 comments
Open

Improve config.ts validation #432

emilgoldsmith opened this issue Jul 29, 2018 · 0 comments

Comments

@emilgoldsmith
Copy link
Member

Expected Behavior

It should validate everything strictly and correctly

Current Behavior

I for example had not provided a ROOT_DIRECTORY variable in CI environment and that should've errored, but it didn't because it just checks for undefined and not for empty string right now

Possible Solution

I would change the validateString function to also somehow take environment into account and enforce that nothing is empty string except for in development where some things like AWS credentials can be an empty string (but things like DB password and ROOT_DIRECTORY still shouldn't)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant