Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper authentication to Express on the CMS #422

Open
emilgoldsmith opened this issue Jul 6, 2018 · 0 comments
Open

Add proper authentication to Express on the CMS #422

emilgoldsmith opened this issue Jul 6, 2018 · 0 comments

Comments

@emilgoldsmith
Copy link
Member

Expected Behavior

It should be in the middleware of express that it checks that the Google Login is valid so that all our api routes including falcor commands are secured.

Current Behavior

Right now anyone could send a postman request to our falcor endpoint and modify our database, the code is even open source so it'd actually be really really easy. I could probably figure out how to delete basically everything in our database using curl on my shell in an hour... Not good

Possible Solution

Add authentication middleware! Think we might be able to use Google Auth docs to write a custom middleware, but this may also be a usecase for http://www.passportjs.org/, seriously consider whether that is overkill when doing this issue though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant