Skip to content

Commit 47950a6

Browse files
committed
PHPStan: Temporarily ignore "issue"
1 parent faacb89 commit 47950a6

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

phpstan.neon

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ parameters:
33
inferPrivatePropertyTypeFromConstructor: true
44
checkMissingIterableValueType: false
55
checkGenericClassInNonGenericObjectType: false
6+
excludePaths:
7+
- src/SafeFunctions.php # Temporary exclude, delete this file in PHP ^8.0
68
ignoreErrors:
79
- "#Method JsonSerializable::jsonSerialize\\(\\) invoked with 1 parameter, 0 required.#"
810
- "#Method .*::.* should return .* but returns .*TheCodingMachine\\\\TDBM\\\\AbstractTDBMObject#"
911
- "#Method .*::.* should return .* but returns TheCodingMachine\\\\TDBM\\\\ResultIterator#"
10-
- '#Strict comparison using === between string and false will always evaluate to false.#'
1112
- "#Call to an undefined method object::#"
1213
- "#expects TheCodingMachine\\\\TDBM\\\\AbstractTDBMObject, object given.#"
1314
- "#should return array<TheCodingMachine\\\\TDBM\\\\AbstractTDBMObject> but returns array<int, object>#"

src/SafeFunctions.php

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ class SafeFunctions
1212
/**
1313
* A wrapper around array_combine that never returns false.
1414
*
15+
* TODO: Remove once we support only PHP ^8.0
16+
*
1517
* @param array<int|string> $keys
1618
* @param mixed[] $values
1719
* @return mixed[]

src/TDBMService.php

+1
Original file line numberDiff line numberDiff line change
@@ -691,6 +691,7 @@ public function save(AbstractTDBMObject $object): void
691691
$this->connection->insert($quotedTableName, $escapedDbRowData, $types);
692692

693693
if (!$isPkSet && count($primaryKeyColumns) === 1) {
694+
/** @var int|false $id @see OCI8Connection::lastInsertId() */
694695
$id = $this->connection->lastInsertId();
695696

696697
if ($id === false) {

0 commit comments

Comments
 (0)