Skip to content

Commit efc63c4

Browse files
committed
Retain specific int details in docblocks
We're already using PHPStan's more-specific-types _some_ of the time - let's do it consistently? See also: thecodingmachine/phpstan-safe-rule#52
1 parent a775bd3 commit efc63c4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

85 files changed

+269
-262
lines changed

CONTRIBUTING.md

+2
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ Intentional changes:
4848
* If the function returned `true` on success and `false` on error, and we have
4949
removed the `false`, then the signature gets changed from `bool` to `void` to
5050
stop people from accidentally writing `if(function()) {...}`
51+
* PHPDoc comments use the more specific type hints from PHPStan, eg `array<string>` rather than
52+
`array`, or `0|1` rather than `int`
5153

5254
Necessary changes / side effects:
5355
* Functions which have optional parameters without defaults (eg `cubrid_bind()` has

generated/8.1/dir.php

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/errorfunc.php

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/filesystem.php

+13-13
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/ftp.php

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/iconv.php

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/image.php

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/json.php

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/mbstring.php

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/network.php

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/oci8.php

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/openssl.php

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/pcre.php

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/posix.php

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/stream.php

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generated/8.1/zlib.php

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)