Skip to content

Commit d87de70

Browse files
authored
don't purge the results from buffer (#752)
1 parent e33f587 commit d87de70

File tree

2 files changed

+2
-42
lines changed

2 files changed

+2
-42
lines changed

src/Parameters/PrefetchDataParameter.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,7 @@ public function resolve(object|null $source, array $args, mixed $context, Resolv
5757
$this->processPrefetch($args, $context, $info, $prefetchBuffer);
5858
}
5959

60-
$result = $prefetchBuffer->getResult($source);
61-
// clear internal storage
62-
$prefetchBuffer->purgeResult($source);
63-
return $result;
60+
return $prefetchBuffer->getResult($source);
6461
});
6562
}
6663

tests/Parameters/PrefetchDataParameterTest.php

Lines changed: 1 addition & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -37,47 +37,10 @@ public function testResolveWithExistingResult(): void
3737
self::assertSame($prefetchResult, $this->deferredValue($resolvedParameterPromise));
3838
}
3939

40-
public function testResolveWithoutExistingResult(): void
41-
{
42-
$prefetchResult = new stdClass();
43-
$source = new stdClass();
44-
$prefetchHandler = function (array $sources, string $second) use ($prefetchResult, $source) {
45-
self::assertSame([$source], $sources);
46-
self::assertSame('rty', $second);
47-
48-
return $prefetchResult;
49-
};
50-
51-
$parameter = new PrefetchDataParameter('field', $prefetchHandler, [
52-
new InputTypeParameter(
53-
name: 'second',
54-
type: Type::string(),
55-
description: '',
56-
hasDefaultValue: false,
57-
defaultValue: null,
58-
argumentResolver: new ArgumentResolver()
59-
)
60-
]);
61-
62-
$context = new Context();
63-
$args = [
64-
'first' => 'qwe',
65-
'second' => 'rty',
66-
];
67-
$buffer = $context->getPrefetchBuffer($parameter);
68-
69-
$resolvedParameterPromise = $parameter->resolve($source, $args, $context, $this->createStub(ResolveInfo::class));
70-
71-
self::assertFalse($buffer->hasResult($source));
72-
self::assertSame([$source], $buffer->getObjectsByArguments($args));
73-
self::assertSame($prefetchResult, $this->deferredValue($resolvedParameterPromise));
74-
self::assertFalse($buffer->hasResult($source));
75-
}
76-
7740
private function deferredValue(Deferred $promise): mixed
7841
{
7942
$syncPromiseAdapter = new SyncPromiseAdapter();
8043

8144
return $syncPromiseAdapter->wait(new Promise($promise, $syncPromiseAdapter));
8245
}
83-
}
46+
}

0 commit comments

Comments
 (0)