Skip to content

Commit 28d47ee

Browse files
authored
Merge pull request #323 from thecodingmachine/hotfix/multiarch
Fixe multiarch arm64 support
2 parents a258b8e + 4d2d966 commit 28d47ee

25 files changed

+358
-175
lines changed

.github/workflows/workflow.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
- name: Build locally
2828
run: |
2929
PHP_VERSION="${{ matrix.php_version }}"
30-
docker buildx bake --pull --load \
30+
docker buildx bake --load \
3131
--set "*.platform=linux/amd64" \
3232
php${PHP_VERSION//.}-${{ matrix.variant }}
3333
docker images --filter=reference=thecodingmachine/php
@@ -42,9 +42,10 @@ jobs:
4242
# Merge ~ push.
4343
if: ${{ github.event_name == 'push' || github.event_name == 'schedule' }}
4444
run: |
45-
PHP_VERSION="${{ matrix.php_version }}"
46-
PHP_PATCH_VERSION=`docker run --rm thecodingmachine/php:${PHP_VERSION}-v4-slim-${{ matrix.variant }} php -v | head -n1 | grep -P '\d+\.\d+\.\d+' -o | head -n1`
47-
PHP_PATCH_MINOR="${PHP_PATCH_VERSION}" docker buildx bake --pull \
45+
PHP_VERSION="${{ matrix.php_version }}" \
46+
PHP_PATCH_VERSION=`docker run --rm thecodingmachine/php:${PHP_VERSION}-v4-slim-${{ matrix.variant }} php -v | head -n1 | grep -P '\d+\.\d+\.\d+' -o | head -n1` \
47+
PHP_PATCH_MINOR="${PHP_PATCH_VERSION}" \
48+
docker buildx bake \
4849
--set "*.platform=linux/amd64,linux/arm64" \
49-
--set=*.output=type=registry \
50+
--set "*.output=type=registry" \
5051
php${PHP_VERSION//.}-${{ matrix.variant }}

Dockerfile.apache

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,13 @@ ARG INSTALL_COMPOSER=1
44
ARG PHP_VERSION
55
ARG GLOBAL_VERSION
66

7-
FROM --platform=$BUILDPLATFORM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-slim-apache
8-
9-
ONBUILD ARG TARGETOS
10-
ONBUILD ARG TARGETARCH
11-
ONBUILD ARG BLACKFIRE_VERSION=1
12-
ENV CONTAINER_OS=${TARGETOS}
13-
ENV CONTAINER_ARCH=${TARGETARCH}
14-
ENV BLACKFIRE_VERSION=${BLACKFIRE_VERSION}
15-
16-
7+
FROM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-slim-apache as baseapp
178
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
189

10+
ARG TARGETOS
11+
ARG TARGETARCH
12+
ARG BLACKFIRE_VERSION=1
13+
1914
# |--------------------------------------------------------------------------
2015
# | Main PHP extensions
2116
# |--------------------------------------------------------------------------

Dockerfile.apache.node10

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
# DO NOT EDIT THIS FILE : Make yours changes in /utils/Dockerfile.*.blueprint)
2-
ARG PHP_VERSION
3-
ARG GLOBAL_VERSION
2+
FROM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-apache as baseapp
3+
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
4+
45
ARG TARGETOS
56
ARG TARGETARCH
67
ARG BLACKFIRE_VERSION=1
78

8-
FROM --platform=$BUILDPLATFORM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-apache
9-
10-
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
11-
129
USER root
1310

1411
ENV BLACKFIRE_VERSION=${BLACKFIRE_VERSION}

Dockerfile.apache.node12

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
# DO NOT EDIT THIS FILE : Make yours changes in /utils/Dockerfile.*.blueprint)
2-
ARG PHP_VERSION
3-
ARG GLOBAL_VERSION
2+
FROM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-apache as baseapp
3+
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
4+
45
ARG TARGETOS
56
ARG TARGETARCH
67
ARG BLACKFIRE_VERSION=1
78

8-
FROM --platform=$BUILDPLATFORM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-apache
9-
10-
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
11-
129
USER root
1310

1411
ENV BLACKFIRE_VERSION=${BLACKFIRE_VERSION}

Dockerfile.apache.node14

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
# DO NOT EDIT THIS FILE : Make yours changes in /utils/Dockerfile.*.blueprint)
2-
ARG PHP_VERSION
3-
ARG GLOBAL_VERSION
2+
FROM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-apache as baseapp
3+
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
4+
45
ARG TARGETOS
56
ARG TARGETARCH
67
ARG BLACKFIRE_VERSION=1
78

8-
FROM --platform=$BUILDPLATFORM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-apache
9-
10-
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
11-
129
USER root
1310

1411
ENV BLACKFIRE_VERSION=${BLACKFIRE_VERSION}

Dockerfile.apache.node16

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
# DO NOT EDIT THIS FILE : Make yours changes in /utils/Dockerfile.*.blueprint)
2-
ARG PHP_VERSION
3-
ARG GLOBAL_VERSION
2+
FROM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-apache as baseapp
3+
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
4+
45
ARG TARGETOS
56
ARG TARGETARCH
67
ARG BLACKFIRE_VERSION=1
78

8-
FROM --platform=$BUILDPLATFORM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-apache
9-
10-
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
11-
129
USER root
1310

1411
ENV BLACKFIRE_VERSION=${BLACKFIRE_VERSION}

Dockerfile.cli

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,13 @@ ARG INSTALL_COMPOSER=1
44
ARG PHP_VERSION
55
ARG GLOBAL_VERSION
66

7-
FROM --platform=$BUILDPLATFORM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-slim-cli
8-
9-
ONBUILD ARG TARGETOS
10-
ONBUILD ARG TARGETARCH
11-
ONBUILD ARG BLACKFIRE_VERSION=1
12-
ENV CONTAINER_OS=${TARGETOS}
13-
ENV CONTAINER_ARCH=${TARGETARCH}
14-
ENV BLACKFIRE_VERSION=${BLACKFIRE_VERSION}
15-
16-
7+
FROM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-slim-cli as baseapp
178
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
189

10+
ARG TARGETOS
11+
ARG TARGETARCH
12+
ARG BLACKFIRE_VERSION=1
13+
1914
# |--------------------------------------------------------------------------
2015
# | Main PHP extensions
2116
# |--------------------------------------------------------------------------

Dockerfile.cli.node10

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
# DO NOT EDIT THIS FILE : Make yours changes in /utils/Dockerfile.*.blueprint)
2-
ARG PHP_VERSION
3-
ARG GLOBAL_VERSION
2+
FROM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-cli as baseapp
3+
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
4+
45
ARG TARGETOS
56
ARG TARGETARCH
67
ARG BLACKFIRE_VERSION=1
78

8-
FROM --platform=$BUILDPLATFORM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-cli
9-
10-
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
11-
129
USER root
1310

1411
ENV BLACKFIRE_VERSION=${BLACKFIRE_VERSION}

Dockerfile.cli.node12

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
# DO NOT EDIT THIS FILE : Make yours changes in /utils/Dockerfile.*.blueprint)
2-
ARG PHP_VERSION
3-
ARG GLOBAL_VERSION
2+
FROM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-cli as baseapp
3+
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
4+
45
ARG TARGETOS
56
ARG TARGETARCH
67
ARG BLACKFIRE_VERSION=1
78

8-
FROM --platform=$BUILDPLATFORM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-cli
9-
10-
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
11-
129
USER root
1310

1411
ENV BLACKFIRE_VERSION=${BLACKFIRE_VERSION}

Dockerfile.cli.node14

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
# DO NOT EDIT THIS FILE : Make yours changes in /utils/Dockerfile.*.blueprint)
2-
ARG PHP_VERSION
3-
ARG GLOBAL_VERSION
2+
FROM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-cli as baseapp
3+
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
4+
45
ARG TARGETOS
56
ARG TARGETARCH
67
ARG BLACKFIRE_VERSION=1
78

8-
FROM --platform=$BUILDPLATFORM thecodingmachine/php:${PHP_VERSION}-${GLOBAL_VERSION}-cli
9-
10-
LABEL authors="Julien Neuhart <[email protected]>, David Négrier <[email protected]>"
11-
129
USER root
1310

1411
ENV BLACKFIRE_VERSION=${BLACKFIRE_VERSION}

0 commit comments

Comments
 (0)