Skip to content

Svelte 5 support #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madeleineostoja opened this issue Sep 4, 2024 · 7 comments
Open

Svelte 5 support #166

madeleineostoja opened this issue Sep 4, 2024 · 7 comments

Comments

@madeleineostoja
Copy link

Any plans to more fully support Svelte 5 now that's in release candidate?

The most notable change to bring svelte-file-dropzone in line with deprecations etc would just be to replace events (on:drag etc) with callbacks (ondrag etc).

I've also noticed that many svelte-file-dropzone props aren't properly reactive when I use it in a Svelte 5 (runes mode) environment. I haven't dug too far into it yet, but my first guess from a quick skim of the codebase is how events are composed.

@arackaf
Copy link
Collaborator

arackaf commented Sep 5, 2024

For sure - once it's stable we'll upgrade to Svelte 5 and bump a major version

@harryqt
Copy link

harryqt commented Oct 31, 2024

Svelte 5 is now stable.

@ronny-rentner
Copy link

This package is dead. Pull requests from years ago not taken care of...

@arackaf
Copy link
Collaborator

arackaf commented Nov 7, 2024

Not dead, but also not a ton of maintainers. I do merge pr's when they come up. I don't see any in the list of open ones that seem important, but if you think otherwise drop a link to which one and I'll take a look

@ronny-rentner
Copy link

Sorry if my previous comment sounded rude. That was not my intention. I just think either merge or close the PRs. It's not a good sign for potential future contributors if pull requests are laying around for more than a year.

@elron
Copy link

elron commented Nov 26, 2024

So, does this package support svelte 5 (runes)?

@arackaf
Copy link
Collaborator

arackaf commented Nov 26, 2024

Not yet. Should still be compatible with Svelte 5 though. Svelte 5 in general should still work with Svelte 4 code.

But yeah - Svelte 5 support is coming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants