Update ESLint configs and fix warnings/errors

Author: mjackson

.eslintignore

@@ -0,0 +1,4 @@
+/packages/*/cjs/*.js
+/packages/*/esm/*.js
+/packages/*/umd/*.js
+/website

.eslintrc

@@ -1,9 +1,6 @@
 {
-  "parser": "babel-eslint",
-  "env": {
-    "node": true
-  },
-  "extends": [
-    "eslint:recommended"
-  ]
+  extends: ["react-app"],
+  rules: {
+    "import/first": 0
+  }
 }

package.json

@@ -4,6 +4,7 @@
   "scripts": {
     "build": "node ./scripts/build.js",
     "clean": "git clean -e '!/website-deploy-key' -e '!/website-deploy-key.pub' -fdX .",
+    "lint": "eslint .",
     "start": "node ./scripts/start.js",
     "test": "jest --projects ./packages/*/"
   },
@@ -13,12 +14,18 @@
     "@babel/plugin-transform-runtime": "^7.5.5",
     "@babel/preset-env": "^7.5.5",
     "@babel/preset-react": "^7.0.0",
-    "babel-eslint": "^10.0.3",
+    "@typescript-eslint/eslint-plugin": "2.x",
+    "@typescript-eslint/parser": "2.x",
+    "babel-eslint": "10.x",
     "babel-jest": "^24.9.0",
     "babel-plugin-dev-expression": "^0.2.2",
-    "eslint": "^6.3.0",
-    "eslint-plugin-import": "^2.18.2",
-    "eslint-plugin-react": "^7.14.3",
+    "eslint": "6.x",
+    "eslint-config-react-app": "^5.0.2",
+    "eslint-plugin-flowtype": "3.x",
+    "eslint-plugin-import": "2.x",
+    "eslint-plugin-jsx-a11y": "6.x",
+    "eslint-plugin-react": "7.x",
+    "eslint-plugin-react-hooks": "1.x",
     "history": "^4.9.0",
     "jest": "^24.9.0",
     "jest-circus": "^24.9.0",

packages/react-router-config/.eslintrc

@@ -1,22 +1,9 @@
 {
-  "parser": "babel-eslint",
-  "env": {
-    "browser": true,
-    "node": true
+  env: {
+    browser: true,
+    commonjs: true
   },
-  "plugins": ["import", "react"],
-  "extends": [
-    "eslint:recommended",
-    "plugin:import/errors",
-    "plugin:react/recommended"
-  ],
-  "rules": {
-    "prefer-arrow-callback": 2,
-    "react/display-name": 0
-  },
-  "settings": {
-    "react": {
-      "version": "15"
-    }
+  rules: {
+    strict: 0
   }
 }

packages/react-router-config/es/matchRoutes.js

@@ -1,5 +1,3 @@
-"use strict";
-
 import warnAboutDeprecatedESMImport from "./warnAboutDeprecatedESMImport.js";
 warnAboutDeprecatedESMImport("matchRoutes");
 

packages/react-router-config/es/renderRoutes.js

@@ -1,5 +1,3 @@
-"use strict";
-
 import warnAboutDeprecatedESMImport from "./warnAboutDeprecatedESMImport.js";
 warnAboutDeprecatedESMImport("renderRoutes");
 

packages/react-router-config/es/warnAboutDeprecatedESMImport.js

@@ -1,5 +1,4 @@
-"use strict";
-
+/* eslint-disable prefer-arrow-callback, no-empty */
 var printWarning = function() {};
 
 if (process.env.NODE_ENV !== "production") {

packages/react-router-config/modules/.eslintrc

@@ -0,0 +1,8 @@
+{
+  env: {
+    commonjs: false
+  },
+  rules: {
+    strict: 2
+  }
+}

packages/react-router-config/modules/__tests__/.eslintrc

@@ -1,10 +1,8 @@
 {
-  "env": {
-    "jest": true
+  env: {
+    jest: true
   },
-  "rules": {
-    "import/no-unresolved": [2, { "ignore": ["react-router", "react-router-config"] }],
-    "react/display-name": 0,
-    "react/prop-types": 0
+  rules: {
+    "no-console": 0
   }
 }

packages/react-router-config/modules/__tests__/integration-test.js

@@ -8,9 +8,10 @@ describe("integration", () => {
   it("generates the same matches in renderRoutes and matchRoutes", () => {
     const rendered = [];
 
-    const Comp = ({ match, route: { routes } }) => (
-      rendered.push(match), renderRoutes(routes)
-    );
+    function Comp({ match, route: { routes } }) {
+      rendered.push(match);
+      return renderRoutes(routes);
+    }
 
     const routes = [
       {
@@ -60,9 +61,10 @@ describe("integration", () => {
   it("generates the same matches in renderRoutes and matchRoutes with pathless routes", () => {
     const rendered = [];
 
-    const Comp = ({ match, route: { routes } }) => (
-      rendered.push(match), renderRoutes(routes)
-    );
+    function Comp({ match, route: { routes } }) {
+      rendered.push(match);
+      return renderRoutes(routes);
+    }
 
     const routes = [
       {
@@ -110,9 +112,10 @@ describe("integration", () => {
   it("generates the same matches in renderRoutes and matchRoutes with routes using exact", () => {
     const rendered = [];
 
-    const Comp = ({ match, route: { routes } }) => (
-      rendered.push(match), renderRoutes(routes)
-    );
+    function Comp({ match, route: { routes } }) {
+      rendered.push(match);
+      return renderRoutes(routes);
+    }
 
     const routes = [
       // should skip
@@ -144,9 +147,10 @@ describe("integration", () => {
   it("generates the same matches in renderRoutes and matchRoutes with routes using exact + strict", () => {
     const rendered = [];
 
-    const Comp = ({ match, route: { routes } }) => (
-      rendered.push(match), renderRoutes(routes)
-    );
+    function Comp({ match, route: { routes } }) {
+      rendered.push(match);
+      return renderRoutes(routes);
+    }
 
     const routes = [
       // should match