-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Onju to use new compoents from HAVPE #104
Comments
Yes, the duplex i2s bus is the problem here. It is possible to get this going by changing the i2s_audio speaker implementation to not initialize the i2s driver again, after the microphone has already initialized the bus. The proper solution is to have official ESPHome support of duplex I2S-Busses. I think it just needs someone to implement that / port over the duplex i2s_audio implementation of esphome_audio. |
How is this a bug with the current config, if the current config does not contain any of the components you mentioned? I have attempted to port those components over and these are the conclusions. Until I a solution will be published, feel free to open a discussion with your own findings, but please don't call it a bug. |
That's only part of the solution, which was tackled in the new components for VPE. I trust those components will make their way into ESPHome soon enough. The unsolvable issue is that both VA and MWW run at 16kHz sample rate and that if you use the same I2S bus, you can't run the input at 16kHz and the output at 48kHz (or any other sampling rate, for that matter). |
I have had surprisingly good success on my Onju Voice with some modified components (namely this: formatBCE/home-assistant-voice-pe@652b155 ) running mic and speaker at 48kHz, and having this very simple resampling implementation. microWakeWord and HACloud still pick up speech totally fine with that. The only reason I haven't published that implementation yet is that native duplex support is missing. I hacked it in by disabling the speakers i2s driver init, but as that is not a very tidy solution, I don't recommend anyone to use it. Also, duplex I2S-Busses were not yet tackled, as Voice-PE does not need support for that. |
@tetele Sorry for adressing it as a bug - if I had made it as a feature request, would that be better? The idea was to see if we together could find a way to implement the new components the best way possible for all of us already got the Onju. Whenever I get my HAVPE, I still will not throw the Onju away, I want the best out of it. Thanks for clearing up the 16/48Hz. |
Hi all,
This is a duplicate of message I wrote here: justLV/onju-voice#76
I've made several custom code versions for the Onju, both with continuous conversation, random greeting messages etc and got full control of the code itself :)
What I wanted to do is implement the updated components for voice_assistant, nabu_microphone and nabu_media_player. I ended up with two different issues yesterday;
1 - The microphone clearly pick up my wakeword, but it does not hear my command (VAD)
2 - Whatever I try to play to the media_player just causes an error (mp3 file etc)
The issue might be the shared i2c bus, but I'm not sure.
I could not import adf_pipeline as prevsiously.
I loaded following in the test configuration:
Full esp32 as for HAVPE:
Then for external_components:
This is the revised settings for audio + media_player + wakeword + voice_assistant:
Spot anything wrong?
The text was updated successfully, but these errors were encountered: