MySQL socket connections time out in 2.9dev

[sdann]

The STARTTLS_SLEEP timeout increase from 1 second to 10 seconds in d1e7498, caused --starttls=mysql to stop working.

The starttls_mysql_dialog() function was using starttls_just_read(), which would return after 1 second. Now, after waiting 10 seconds, the server gives up on the connection and resets TCP.

The proper fix is to read the MySQL reply as a stream, detect its size from its header, and return after reading that many bytes, instead of relying on a timeout or newline.

[drwetter]

A guy gave me access to a sendmail SMTP server which needed that. Testssl.sh otherwise tore down the whole connection. From my perspective it didn't make sense in the first place to impose a timeout of only one second.

10 is maybe on the high side. We could change that to a reasonable, lower value or do a service detection and then readjust it.

You can also set this variable by hand, i.e. STARTTLS_SLEEP=X ./testssl.sh <mycmdline>.

Can you try what works for you and what not?