You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Drop support for {framework}-testing-library module imports, in favor of supporting only the testing-library scoped format (@testing-library/{framework})
There is an exception for Marko Testing Library tho.
changed the title [-]Drop support for {framework}-testing-library module imports[/-][+]Drop support for `{framework}-testing-library` module imports[/+]on Aug 4, 2022
This technically applies to all rules, since we check both import declarations and require call expressions in the detect-testing-library-utils. If you open lib/create-testing-library-rule/detect-testing-library-utils.ts in line 1036, you'll see we are detecting Testing Library imports with require() in there. We would have to remove that block entirely, and remove/update all the examples importing with require().
Activity
[-]Drop support for {framework}-testing-library module imports[/-][+]Drop support for `{framework}-testing-library` module imports[/+]skovy commentedon Oct 19, 2022
Is this primarily for
no-dom-import
, or does this affect other rules?Belco90 commentedon Oct 19, 2022
This technically applies to all rules, since we check both import declarations and require call expressions in the
detect-testing-library-utils
. If you openlib/create-testing-library-rule/detect-testing-library-utils.ts
in line 1036, you'll see we are detecting Testing Library imports withrequire()
in there. We would have to remove that block entirely, and remove/update all the examples importing withrequire()
.skovy commentedon Oct 20, 2022
Ah that makes sense, thanks for that additional context! I'll see if I can pick this up in the coming days/weeks
Belco90 commentedon Jan 10, 2023
Taking care of this one.
Belco90 commentedon Aug 1, 2023
Back to TODO.