Skip to content

Drop support for {framework}-testing-library module imports #628

@Belco90

Description

@Belco90
Member

Drop support for {framework}-testing-library module imports, in favor of supporting only the testing-library scoped format (@testing-library/{framework})

There is an exception for Marko Testing Library tho.

Activity

changed the title [-]Drop support for {framework}-testing-library module imports[/-] [+]Drop support for `{framework}-testing-library` module imports[/+] on Aug 4, 2022
skovy

skovy commented on Oct 19, 2022

@skovy
Collaborator

Is this primarily for no-dom-import, or does this affect other rules?

Belco90

Belco90 commented on Oct 19, 2022

@Belco90
MemberAuthor

This technically applies to all rules, since we check both import declarations and require call expressions in the detect-testing-library-utils. If you open lib/create-testing-library-rule/detect-testing-library-utils.ts in line 1036, you'll see we are detecting Testing Library imports with require() in there. We would have to remove that block entirely, and remove/update all the examples importing with require().

skovy

skovy commented on Oct 20, 2022

@skovy
Collaborator

Ah that makes sense, thanks for that additional context! I'll see if I can pick this up in the coming days/weeks

moved this from Todo to In Progress in eslint-plugin-testing-library v6on Jan 10, 2023
self-assigned this
on Jan 10, 2023
Belco90

Belco90 commented on Jan 10, 2023

@Belco90
MemberAuthor

Taking care of this one.

moved this from In Progress to Todo in eslint-plugin-testing-library v6on Aug 1, 2023
Belco90

Belco90 commented on Aug 1, 2023

@Belco90
MemberAuthor

Back to TODO.

removed their assignment
on Aug 1, 2023
added
v7Next major v7
and removed
v6Next major v6
on Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BREAKING CHANGEThis change will require a major version bumpv7Next major v7

    Type

    No type

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Belco90@skovy@MichaelDeBoey

        Issue actions

          Drop support for `{framework}-testing-library` module imports · Issue #628 · testing-library/eslint-plugin-testing-library