Skip to content

Commit 963afb7

Browse files
authored
Embedding Projector: exit select mode onMouseUp (#6288)
* Motivation for features / changes When Shift key is used to select points and is released before mouseUp, UI does not exist selection mode after mouse is released, leaving a permanent rectangular selection box with no way of panning. * Technical description of changes Reset orbit mode properly after mouse is released * Screenshots of UI changes * Detailed steps to verify changes work correctly (as executed by you) * Alternate designs / implementations considered
1 parent 9e02afe commit 963afb7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tensorboard/plugins/projector/vz_projector/scatterPlot.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ export class ScatterPlot {
334334
}
335335
/** When we stop dragging/zooming, return to normal behavior. */
336336
private onMouseUp(e: any) {
337-
if (this.selecting) {
337+
if (this.selecting || !this.orbitCameraControls.enabled) {
338338
this.orbitCameraControls.enabled = true;
339339
this.rectangleSelector.onMouseUp();
340340
this.render();

0 commit comments

Comments
 (0)