Skip to content

Commit c319db3

Browse files
address comments
1 parent 41e0442 commit c319db3

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

toolings/tfjs-debugger/src/app/components/input_selector/input_selector.component.spec.ts

+5-4
Original file line numberDiff line numberDiff line change
@@ -74,19 +74,20 @@ describe('InputSelector', () => {
7474
expect(selectEle.textContent)
7575
.toBe(fixture.componentInstance.inputTypes[0].label);
7676

77-
// After updating the url with inputTypeId = CONST, verify that the
78-
// input type selector has the correct one selected.
77+
// After updating the url with inputTypeId = CUSTOM_VALUE, verify that
78+
// the input type selector has the correct one selected.
7979
router.navigate([], {
8080
queryParams: {
8181
[appendConfigIndexToKey(
8282
UrlParamKey.SELECTED_INPUT_TYPE_ID,
83-
fixture.componentInstance.configIndex)]: `${InputTypeId.CONST}`,
83+
fixture.componentInstance.configIndex)]:
84+
`${InputTypeId.CUSTOM_VALUE}`,
8485
}
8586
});
8687
detectChanges();
8788

8889
const inputType = fixture.componentInstance.inputTypes.find(
89-
inputType => inputType.id === InputTypeId.CONST)!;
90+
inputType => inputType.id === InputTypeId.CUSTOM_VALUE)!;
9091
expect(selectEle.textContent).toBe(inputType.label);
9192
}));
9293

toolings/tfjs-debugger/src/app/components/input_selector/input_selector.component.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ export class InputSelector implements OnInit, OnDestroy {
5050
// TODO: the following types are disabled for now. Will enable them as they
5151
// are implemented.
5252
{
53-
id: InputTypeId.CONST,
54-
label: 'Constant',
53+
id: InputTypeId.CUSTOM_VALUE,
54+
label: 'Custom value',
5555
disabled: true,
5656
},
5757
{

toolings/tfjs-debugger/src/app/data_model/input_type.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
/** Input type ids. */
1919
export enum InputTypeId {
2020
RANDOM,
21-
CONST,
21+
CUSTOM_VALUE,
2222
IMAGE,
2323
SAME_AS_CONFIG1,
2424
}

0 commit comments

Comments
 (0)