Lint tfjs-tflite-node

Author: mattsoulanille

.gitignore

@@ -1,4 +1,4 @@
-/node_modules
+node_modules
 *~
 #*#
 build/

tfjs-tflite-node/package.json

@@ -16,7 +16,8 @@
     "build": "node-gyp rebuild && tsc",
     "build-deps": "cd ../link-package && yarn build",
     "test-dev": "jasmine --config=jasmine.json",
-    "test": "yarn build && yarn test-dev"
+    "test": "yarn build && yarn test-dev",
+    "lint": "tslint -p . -t verbose"
   },
   "dependencies": {
     "bindings": "^1.5.0",
@@ -33,6 +34,8 @@
     "jasmine": "^4.0.2",
     "jpeg-js": "^0.4.3",
     "node-gyp": "^8.4.1",
+    "tslint": "^6.1.3",
+    "tslint-no-circular-imports": "^0.7.0",
     "typescript": "^4.5.4"
   }
 }

tfjs-tflite-node/src/delegate_plugin.ts

@@ -15,16 +15,15 @@
  * =============================================================================
  */
 
-
 // TODO(mattsoulanille): Move this to @tensorflow/tfjs-tflite
 export interface TFLiteDelegatePlugin {
   readonly name: string;
   readonly tfliteVersion: string;
-  readonly options: [string, string][],
+  readonly options: Array<[string, string]>;
   readonly node?: {
     path: string;
-  },
+  };
   readonly browser?: {
     url: string;
-  },
+  };
 }

tfjs-tflite-node/src/index.ts

@@ -23,20 +23,23 @@ export * from './delegate_plugin';
 import {TFLiteDelegatePlugin} from './delegate_plugin';
 import fetch from 'node-fetch';
 
+// tslint:disable-next-line:no-require-imports
 const addon = require('bindings')('node_tflite_binding');
 
 interface InterpreterOptions {
   threads?: number;
   delegate?: {
     path: string;
-    options: [string, string][];
-  }
+    options: Array<[string, string]>;
+  };
 }
 
+// tslint:disable-next-line:variable-name
 export const TFLiteNodeModelRunner = addon.Interpreter as {
   new(model: ArrayBuffer, options: InterpreterOptions): TFLiteWebModelRunner;
 };
 
+// tslint:disable-next-line:variable-name
 export const TensorInfo = addon.TensorInfo as {
   new(): TFLiteWebModelRunnerTensorInfo;
 };
@@ -60,7 +63,7 @@ async function createModel(model: string | ArrayBuffer,
 
   const interpreterOptions: InterpreterOptions = {
     threads: options?.numThreads ?? 4,
-  }
+  };
 
   const firstDelegate = options?.delegates?.[0];
   if (options?.delegates?.length > 1) {
@@ -73,7 +76,7 @@ async function createModel(model: string | ArrayBuffer,
       interpreterOptions.delegate = {
         path: delegatePath,
         options: firstDelegate.options,
-      }
+      };
     }
   }
   return new TFLiteNodeModelRunner(modelData, interpreterOptions);

tfjs-tflite-node/src/index_test.ts

@@ -15,15 +15,12 @@
  * =============================================================================
  */
 
-import { loadTFLiteModel, TFLiteNodeModelRunner} from './index';
+import {loadTFLiteModel, TFLiteNodeModelRunner} from './index';
 import * as fs from 'fs';
-import { TFLiteWebModelRunner } from '@tensorflow/tfjs-tflite/dist/types/tflite_web_model_runner';
+import {TFLiteWebModelRunner} from '@tensorflow/tfjs-tflite/dist/types/tflite_web_model_runner';
 import '@tensorflow/tfjs-backend-cpu';
 import * as jpeg from 'jpeg-js';
 
-//import * as SegfaultHandler from 'segfault-handler';
-//SegfaultHandler.registerHandler('crash.log');
-
 describe('interpreter', () => {
   let model: ArrayBuffer;
   let modelRunner: TFLiteWebModelRunner;
@@ -51,7 +48,7 @@ describe('interpreter', () => {
   });
 
   it('runs infer', () => {
-    let outputs = modelRunner.getOutputs();
+    const outputs = modelRunner.getOutputs();
     modelRunner.infer();
     expect(outputs[0].data()).toBeDefined();
   });
@@ -147,7 +144,8 @@ describe('float32 support', () => {
   let labels: string[];
 
   beforeEach(() => {
-    model = fs.readFileSync('./test_data/teachable_machine_float.tflite').buffer;
+    model = fs.readFileSync('./test_data/teachable_machine_float.tflite')
+      .buffer;
     modelRunner = new TFLiteNodeModelRunner(model, {});
     labels = ['class1', 'class2'];
 
@@ -184,7 +182,8 @@ describe('float32 support', () => {
 // the web. Alternatively, serve the model locally.
 describe('loading model from the web', () => {
   it('loads a model from the web', async () => {
-    const model = await loadTFLiteModel('https://tfhub.dev/sayakpaul/lite-model/cartoongan/fp16/1');
+    const url = 'https://tfhub.dev/sayakpaul/lite-model/cartoongan/fp16/1';
+    const model = await loadTFLiteModel(url);
     expect(model).toBeDefined();
   });
 });

tfjs-tflite-node/src/tflite_model.ts

@@ -312,7 +312,6 @@ export class TFLiteModel implements InferenceModel {
   }
 }
 
-
 /**
  * Returns the compatible tfjs DataType from the given TFLite data type.
  *

tfjs-tflite-node/tslint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../tslint.json"
+}