Skip to content

Commit d8c8c32

Browse files
authored
fix: Resolve S3 crash issue (#2120)
* Change tensorflow installation command and add patch_cmds to aws-cpp-sdk to prevent exception * match aws-sdk-cpp version * rollback WORKSPACE and implement destructor for AWSLogSystem * apply lint
1 parent 114cb4e commit d8c8c32

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

Diff for: tensorflow_io/core/filesystems/s3/aws_logging.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class AWSLogSystem : public Aws::Utils::Logging::LogSystemInterface {
3232
static void ShutdownAWSLogging();
3333

3434
explicit AWSLogSystem(Aws::Utils::Logging::LogLevel log_level);
35-
virtual ~AWSLogSystem() = default;
35+
virtual ~AWSLogSystem() { ShutdownAWSLogging(); }
3636

3737
// Gets the currently configured log level.
3838
Aws::Utils::Logging::LogLevel GetLogLevel(void) const override {

Diff for: third_party/aws-sdk-cpp.BUILD

+3-3
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,10 @@ cc_library(
7676
"aws-cpp-sdk-core/include/aws/core/utils/crypto/openssl/*.h", # UTILS_CRYPTO_OPENSSL_HEADERS
7777
]),
7878
defines = [
79-
'AWS_SDK_VERSION_STRING=\\"1.7.366\\"',
79+
'AWS_SDK_VERSION_STRING=\\"1.8.187\\"',
8080
"AWS_SDK_VERSION_MAJOR=1",
81-
"AWS_SDK_VERSION_MINOR=7",
82-
"AWS_SDK_VERSION_PATCH=366",
81+
"AWS_SDK_VERSION_MINOR=8",
82+
"AWS_SDK_VERSION_PATCH=187",
8383
"ENABLE_OPENSSL_ENCRYPTION=1",
8484
"ENABLE_CURL_CLIENT=1",
8585
"OPENSSL_IS_BORINGSSL=1",

Diff for: tools/docker/build.Dockerfile

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ ARG BAZEL_OPTIMIZATION
99
ADD . /opt/io
1010
WORKDIR /opt/io
1111

12-
RUN python${PYTHON_VERSION} -m pip install tensorflow>=${TENSORFLOW_VERSION}
12+
RUN python${PYTHON_VERSION} -m pip install $(grep tensorflow tensorflow_io/python/ops/version_ops.py | cut -d '"' -f 2)
1313

1414
RUN python$PYTHON_VERSION -m pip uninstall -y tensorflow-io-gcs-filesystem
1515

@@ -18,4 +18,3 @@ RUN python$PYTHON_VERSION tools/build/configure.py
1818
RUN cat .bazelrc
1919

2020
RUN TF_PYTHON_VERSION=${PYTHON_VERSION} bazel build --copt="-fPIC" [email protected]_manylinux2014-cuda11.8-cudnn8.6-tensorrt8.4_config_cuda//crosstool:toolchain --noshow_progress --verbose_failures ${BAZEL_OPTIMIZATION} -- //tensorflow_io/... //tensorflow_io_gcs_filesystem/...
21-

0 commit comments

Comments
 (0)