Skip to content

Conversation

@leigeng1997
Copy link

add a rounding function in the function "coord_to_id" to avoid incorrect conversions caused by numerical errors

@yurielnf yurielnf changed the title Main add round when discretizing variable in quantics Feb 17, 2025
@yurielnf
Copy link
Contributor

Thanks for your proposal @leigeng1997 ! I have tried this branch locally and it doesn't pass the tests. However this can be fixed.
The problem I see is that this change has a non trivial effect on the convergence of tci. I need to observe in detail if the effect is systematically bad or not. Let's wait before merging ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants