Skip to content

Commit be57949

Browse files
author
Jessica Shi
committed
fix bugs, realign with command line tool
1 parent 614d883 commit be57949

File tree

3 files changed

+35
-26
lines changed

3 files changed

+35
-26
lines changed

javascripts/demo.js

Lines changed: 29 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ function demo() {
139139
var parameterInfo = scheduleCommands[command][i];
140140
var defaultValue = "";
141141

142-
if (parameterInfo[0] === "default") {
142+
if (parameterInfo[0] === "default" || parameterInfo[0] === "predefined dropdown") {
143143
defaultValue = parameterInfo[1];
144144
}
145145
model.schedule[row]["parameters"].push(defaultValue);
@@ -580,19 +580,20 @@ function demo() {
580580
0: ["index dropdown", [1, "0"], [2, "1"]],
581581
1: ["default", ""],
582582
2: ["default", ""],
583-
3: ["number"]
583+
3: ["text"]
584584
},
585585
divide: {
586586
parameters: ["Divided IndexVar", "Outer IndexVar", "Inner IndexVar", "Divide Factor"],
587587
0: ["index dropdown", [1, "0"], [2, "1"]],
588588
1: ["default", ""],
589589
2: ["default", ""],
590-
3: ["number"]
590+
3: ["text"]
591591
},
592592
precompute: {
593-
parameters: ["Original IndexVar", "Workspace IndexVar"],
593+
parameters: ["Original IndexVar", "Workspace IndexVar", "Precomputed Expr"],
594594
0: ["index dropdown", [1, ""]],
595-
1: ["default", ""]
595+
1: ["default", ""],
596+
2: ["long text"]
596597
},
597598
reorder: {
598599
parameters: ["Reordered IndexVar", "Reordered IndexVar"],
@@ -603,13 +604,13 @@ function demo() {
603604
parameters: ["Original IndexVar", "Bounded IndexVar", "Bound", "Bound Type"],
604605
0: ["index dropdown", [1, "bound"]],
605606
1: ["default", ""],
606-
2: ["number"],
607+
2: ["text"],
607608
3: ["predefined dropdown", "Max Exact", "Min Exact", "Min Constraint", "Max Exact", "Max Constraint"]
608609
},
609610
unroll: {
610611
parameters: ["Unrolled IndexVar", "Unroll Factor"],
611612
0: ["index dropdown"],
612-
1: ["number"]
613+
1: ["text"]
613614
},
614615
parallelize: {
615616
parameters: ["Parallel IndexVar", "Hardware", "Race Strategy"],
@@ -622,12 +623,13 @@ function demo() {
622623
var tblScheduleView = {
623624
makeParameters: function(row, command) {
624625
// a normal textfield
625-
function empty(parameterName, inputId, input) {
626+
function empty(parameterName, inputId, input, long = false) {
626627
var parameter = "<li>"
627628
parameter += "<div class=\"schedule-input mdl-textfield mdl-js-textfield ";
628-
parameter += "mdl-textfield--floating-label getmdl-select\">";
629-
parameter += "<input class=\"space-font mdl-textfield__input\" "
630-
parameter += "type=\"text\" autocomplete=\"off\" value = \"";
629+
parameter += "mdl-textfield--floating-label getmdl-select has-placeholder ";
630+
parameter += long ? "schedule-input-long" : "";
631+
parameter += "\"><input class=\"space-font mdl-textfield__input\""
632+
parameter += "type=\"text\" autocomplete=\"off\" placeholder=\"\" value = \"";
631633
parameter += input;
632634
parameter += "\" id=\"";
633635
parameter += inputId;
@@ -641,14 +643,14 @@ function demo() {
641643
function dropdown(paramterName, inputId, input, defaultValue = "", useMonospace = true) {
642644
var parameter = "<li>";
643645
parameter += "<div class=\"schedule-input dropdown mdl-textfield mdl-js-textfield ";
644-
parameter += "mdl-textfield--floating-label getmdl-select\">";
646+
parameter += "mdl-textfield--floating-label getmdl-select has-placeholder\">";
645647
parameter += "<input class=\"mdl-textfield__input ";
646648
if (useMonospace) {
647649
parameter += "space-font";
648650
}
649651
parameter += "\" data-toggle=\"dropdown\" id=\"";
650652
parameter += inputId;
651-
parameter += "\" type=\"text\" readonly value=\"";
653+
parameter += "\" type=\"text\" readonly placeholder=\"\" value=\"";
652654
parameter += input ? input : defaultValue;
653655
parameter += "\"><label data-toggle=\"dropdown\">";
654656
parameter += "<i class=\"mdl-icon-toggle__label ";
@@ -727,9 +729,12 @@ function demo() {
727729
case "default":
728730
parameters += empty(parameterName, inputId, input);
729731
break;
730-
case "number":
732+
case "text":
731733
parameters += empty(parameterName, inputId, input);
732734
break;
735+
case "long text":
736+
parameters += empty(parameterName, inputId, input, true);
737+
break;
733738
}
734739
}
735740

@@ -947,36 +952,36 @@ function demo() {
947952
}
948953
}
949954

950-
command += " -set-schedule=";
951955
for (var i = 0; i < model.schedule.length; ++i) {
956+
tempCommand = " -s=\"";
957+
952958
var scheduleCommand = model.schedule[i]["command"];
953959
if (!scheduleCommand) { continue; }
954960

955-
var tempCommand = scheduleCommand + "-";
961+
tempCommand += scheduleCommand + "(";
956962
var valid = true;
957963

958964
if (scheduleCommand === "reorder") {
959-
tempCommand += model.schedule[i]["numReordered"] + "-";
965+
tempCommand += model.schedule[i]["numReordered"] + ",";
960966
}
961967

962968
for (var param of model.schedule[i]["parameters"]) {
963-
param = param.toString().replace(" ", "");
969+
param = param.toString().replace(/ /g, "");
964970
if (!param) {
965971
valid = false;
966972
break;
967973
}
968-
tempCommand += param + "-";
974+
tempCommand += param + ",";
969975
}
970976

971-
console.log(tempCommand);
977+
tempCommand = tempCommand.substring(0, tempCommand.length - 1)
978+
tempCommand += ")\"";
972979

973980
if (valid) {
974981
// only add if user inputted all parameters
975982
command += tempCommand;
976983
}
977984
}
978-
command += "q";
979-
console.log(command);
980985

981986
var req = $.ajax({
982987
type: "POST",
@@ -1065,7 +1070,7 @@ function demo() {
10651070
]
10661071
},
10671072
mttkrp: { name: "MTTKRP",
1068-
code: "A(i,j) = B(i,k,l) * C(k,j) * D(l,j)",
1073+
code: "A(i,j) = B(i,k,l) * D(l,j) * C(k,j)",
10691074
formats: {
10701075
A: { name: "Dense array", levels: { formats: ["d", "d"], ordering: [0, 1] } },
10711076
B: { name: "CSF", levels: { formats: ["s", "s", "s"], ordering: [0, 1, 2] } },
@@ -1080,7 +1085,7 @@ function demo() {
10801085
},
10811086
{
10821087
command: "precompute",
1083-
parameters: ["j", "j"]
1088+
parameters: ["j", "j", "B(i,k,l) * D(l,j)"]
10841089
},
10851090
{
10861091
command: "split",

stylesheets/dropdown.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,5 @@
4242
}
4343

4444
.schedule-input li {
45-
width: 170px;
45+
width: 120px;
4646
}

stylesheets/style.css

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,11 @@ ul {
218218
}
219219

220220
.schedule-input {
221-
width: 170px;
221+
width: 120px;
222+
}
223+
224+
.schedule-input-long {
225+
width: 200px;
222226
}
223227

224228
.schedule-list {

0 commit comments

Comments
 (0)