You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the taco/array_algebra branch generates incorrect xorOp lowering code for 2+ order tensors (found by @rohany)
The lowering code seems to only compare for the iteration algebra on the highest level of coordinates and does not check the case where input1_crd1 == input2_crd1 but input1_crd2 != input2_crd2.
Created a branch in taco/array_algebra_xor_fix that:
adds in a new test called XorOpOrder2 in test/tests-lower.cpp to test the 2-dimensional C(i, j) = xorOp(A(i, j), B(i, j))
Applies a patch from @rohany in taco/lower/lowerer-impl.cpp in lowerMergeCases(...) that should fix this bug
In particular, the code doesn't generate a case for the omitter point when the value on the first mode is equal to the value on the of the first mode of the other tensor. Instead, it needs to emit the case there, and recurse down into the point.
Activity
rohany commentedon Mar 9, 2021
@RawnH do you have suggestions for this bug? A the problem can be seen in the generated code for a 2-d element wise xor op:
In particular, the code doesn't generate a case for the omitter point when the value on the first mode is equal to the value on the of the first mode of the other tensor. Instead, it needs to emit the case there, and recurse down into the point.
rawnhenry commentedon Mar 9, 2021
I will look at this when I look at the other issue.