Skip to content

validate: implement validation strategy for ufunc benchmarks #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rohany opened this issue Mar 6, 2021 · 0 comments
Open

validate: implement validation strategy for ufunc benchmarks #5

rohany opened this issue Mar 6, 2021 · 0 comments

Comments

@rohany
Copy link
Collaborator

rohany commented Mar 6, 2021

@weiya711 double check that I got this correct.

When some flag is passed to the benchmarks, both the taco and python benchmarks should dump their result tensor to a given directory with some unique key (that is the same between taco and python). Once all of the benchmarks run, we can run a diff between each of the files (generated by python and taco) to ensure that the taco code is correct.
rohany added a commit that referenced this issue Mar 12, 2021
@rohany
*: add scaffolding and basic cross validation between taco and numpy
caa46a4 
Relates to #5.

The validation supported in this PR just ensures that the number of
non-zeros in the output is the same between the numpy and taco.
@rohany rohany mentioned this issue Mar 12, 2021
Merged
rohany added a commit that referenced this issue Mar 12, 2021
@rohany
*: add scaffolding and basic cross validation between taco and numpy
5511b6d 
Relates to #5.

The validation supported in this PR just ensures that the number of
non-zeros in the output is the same between the numpy and taco.
rohany added a commit that referenced this issue Mar 12, 2021
@rohany
*: add scaffolding and basic cross validation between taco and numpy
c89be68 
Relates to #5.

The validation supported in this PR just ensures that the number of
non-zeros in the output is the same between the numpy and taco.
rohany added a commit that referenced this issue Mar 12, 2021
@rohany
*: add scaffolding and basic cross validation between taco and numpy
46fceb1 
Relates to #5.

The validation supported in this PR just ensures that the number of
non-zeros in the output is the same between the numpy and taco.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rohany