Spring boot `workers-auto-discovery` - Workflow vs Activities

[gauravthadani]

Context:

The intention is that a user generally has control over the activity beans they are creating, 
but has less control over the classes that may be in their path, thus justifying a way to exclude them.

the config name should have been maybe workflow-packages to represent the intention

config sample:

  temporal:
    workers-auto-discovery:
      packages:
        - io.temporal.spring.boot.autoconfigure.bytaskqueue

• While all Activities are loaded as Beans, they depend on the boolean workers-auto-discovery
• And then the filter for packages only applied Workflows.

Essentially, if no packages are declared, then no Activities/Beans are registered either

Expected Behavior

Activity beans to be loaded when

• workers-auto-discovery present in config despite the presence of packages

Preference to rename packages to workflow-packages

Actual Behavior

No Activities registered, if no packages specified - link

Additional notes

• thought issue is worthwhile given single use Activity feature.

Steps to Reproduce the Problem

Specifications

• Version:
• Platform:

[robzienert]

The issue doesn't quite capture the issue at hand: One of the bugs is that activities are not component scanned for registration to a worker unless spring.temporal.workers-auto-discovery.packages is non-empty.

The config is apparently meant to only be used for scanning for workflow implementations at these package roots, but activity auto-discovery registration is not activated unless this value is set. So, there are two potential solutions: (1) Always register @ActivityImpl beans with matching workers, or (2) introduce a flag (e.g. spring.temporal.workers-auto-discovery.register-activities: true|false) to control whether or not activity beans should be auto-registered.

My inclination would be that (2) is most-appropriate, as (1) seems like it could be backwards-incompatible.