Make hyper and tokio optional dependencies #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two default features
runtime-tokioandconnector-hyper, which control if the default runtime / connector implementation is present.This change makes it possible to use this crate in environments where Tokio and/or hyper cannot be used, and the end user wants to provide their own Connector implementation (e.g. Cloudflare Worker (worker-rs, Fetch), Phala Network (sidevm, see #266)).
Notably,
Api::send_timeoutcurrently depends on Tokio, so we have to disable that ifruntime-tokiois not selected. In those cases, we are forced to useApi::sendwithout timeouts inUpdatesStream. This may be suboptimal, but should yield correct behavior nevertheless.