From 2878b411a6723e90ae9b8eac4ecb30c2ef3beb76 Mon Sep 17 00:00:00 2001
From: Bradley White <14679271+devbww@users.noreply.github.com>
Date: Tue, 26 Dec 2023 11:15:21 -0500
Subject: [PATCH] Stop trimming "redundant" trailing transitions. (#281)

Even when the last two transitions share a type, we should not
discard the last transition as that might change the point at
which we start to apply the POSIX spec for future transitions.

This will start to make a difference in zoneinfo files compiled
using the 2023d zic for Antarctica/Macquarie, Europe/Riga,
Europe/Tallinn, Europe/Vilnius, and Pacific/Norfolk, where we
previously would have added daylight-time transitions in years
where they did not really apply.
---
 src/time_zone_info.cc | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/src/time_zone_info.cc b/src/time_zone_info.cc
index eae7861..cc4b001 100644
--- a/src/time_zone_info.cc
+++ b/src/time_zone_info.cc
@@ -765,19 +765,6 @@ bool TimeZoneInfo::Load(ZoneInfoSource* zip) {
     version_ = zip->Version();
   }
 
-  // Trim redundant transitions. zic may have added these to work around
-  // differences between the glibc and reference implementations (see
-  // zic.c:dontmerge) or to avoid bugs in old readers. For us, they just
-  // get in the way when we do future_spec_ extension.
-  while (hdr.timecnt > 1) {
-    if (!EquivTransitions(transitions_[hdr.timecnt - 1].type_index,
-                          transitions_[hdr.timecnt - 2].type_index)) {
-      break;
-    }
-    hdr.timecnt -= 1;
-  }
-  transitions_.resize(hdr.timecnt);
-
   // Ensure that there is always a transition in the first half of the
   // time line (the second half is handled below) so that the signed
   // difference between a civil_second and the civil_second of its