Skip to content

Commit cda8888

Browse files
committed
PEP 8 changes
1 parent 49bd57f commit cda8888

File tree

9 files changed

+17
-12
lines changed

9 files changed

+17
-12
lines changed

django_url_shortener/settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
DATABASES = {
1616
'default': {
17-
'ENGINE': '', # Add 'postgresql_psycopg2', 'mysql', 'sqlite3' or 'oracle'.
17+
'ENGINE': '', # Add 'postgresql_psycopg2', 'mysql', 'sqlite3' or 'oracle'.
1818
'NAME': '', # Or path to database file if using sqlite3.
1919
'USER': '', # Not used with sqlite3.
2020
'PASSWORD': '', # Not used with sqlite3.

manage.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
import sys
44

55
if __name__ == "__main__":
6-
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "django_url_shortener.settings")
6+
os.environ.setdefault("DJANGO_SETTINGS_MODULE",
7+
"django_url_shortener.settings")
78

89
from django.core.management import execute_from_command_line
910

shortener/admin.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22

33
from shortener.models import Link
44

5+
56
class LinkAdmin(admin.ModelAdmin):
67
pass
78

9+
810
admin.site.register(Link, LinkAdmin)

shortener/forms.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@
33
from shortener.baseconv import base62, EncodingError
44
from shortener.models import Link
55

6+
67
too_long_error = "Your custom name is too long. Are you sure you wanted a shortening service? :)"
78

9+
810
class LinkSubmitForm(forms.Form):
911
url = forms.URLField(
1012
label='URL to be shortened',)

shortener/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
from shortener.baseconv import base62
77

8+
89
class Link(models.Model):
910
"""
1011
Model that represents a shortened URL

shortener/templatetags/shortener_helpers.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
register = template.Library()
44

5+
56
@register.simple_tag(takes_context=True)
67
def short_url(context, link):
78
request = context['request']

shortener/tests.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,15 @@
1616
class TemplateTagTestCase(TestCase):
1717
def setUp(self):
1818
self.HTTP_HOST = "django.testserver"
19-
self.factory = RequestFactory(HTTP_HOST = self.HTTP_HOST)
19+
self.factory = RequestFactory(HTTP_HOST=self.HTTP_HOST)
2020

2121
def test_short_url(self):
2222
link = Link.objects.create(url='http://www.python.org/')
2323
request = self.factory.get(reverse('index'))
2424
out = Template(
2525
"{% load shortener_helpers %}"
2626
"{% short_url link %}"
27-
).render(RequestContext(request, {'link': link,}))
27+
).render(RequestContext(request, {'link': link}))
2828
self.assertEqual(
2929
out, 'http://%s/%s' % (self.HTTP_HOST, link.to_base62()))
3030

@@ -36,19 +36,19 @@ def test_short_url_with_custom(self):
3636
out = Template(
3737
"{% load shortener_helpers %}"
3838
"{% short_url link %}"
39-
).render(RequestContext(request, {'link': link,}))
39+
).render(RequestContext(request, {'link': link}))
4040
self.assertEqual(
4141
out, 'http://%s/%s' % (self.HTTP_HOST, link.to_base62()))
4242

4343

4444
class ViewTestCase(TestCase):
4545
def setUp(self):
4646
# needed for the short_url templatetag
47-
self.client = Client(HTTP_HOST = "django.testserver")
47+
self.client = Client(HTTP_HOST="django.testserver")
4848

4949
def test_submit(self):
5050
url = u'http://www.python.org/'
51-
response = self.client.post(reverse('submit'), {'url': url,})
51+
response = self.client.post(reverse('submit'), {'url': url})
5252
self.assertEqual(response.status_code, 200)
5353
self.assertTemplateUsed(response, 'shortener/submit_success.html')
5454
self.assertIn('link', response.context)
@@ -123,7 +123,7 @@ def test_submit_long_custom(self):
123123

124124
def test_follow(self):
125125
url = u'http://www.python.org/'
126-
response = self.client.post(reverse('submit'), {'url': url,})
126+
response = self.client.post(reverse('submit'), {'url': url})
127127
self.assertEqual(response.status_code, 200)
128128
self.assertTemplateUsed(response, 'shortener/submit_success.html')
129129

shortener/urls.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,3 @@
77
url(r'^submit/$', 'submit', name='submit'),
88
url(r'^(?P<base62_id>\w+)$', 'follow', name='follow'),
99
)
10-

shortener/views.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def info(request, base62_id):
2626
View which shows information on a particular link
2727
"""
2828
link = get_object_or_404(Link, id=base62.to_decimal(base62_id))
29-
return render(request, 'shortener/link_info.html', {'link': link,})
29+
return render(request, 'shortener/link_info.html', {'link': link})
3030

3131

3232
@require_POST
@@ -55,6 +55,5 @@ def index(request):
5555
values = {
5656
'link_form': LinkSubmitForm(),
5757
'recent_links': Link.objects.all().order_by('-date_submitted')[:5],
58-
'most_popular_links': Link.objects.all().order_by('-usage_count')[:5],}
58+
'most_popular_links': Link.objects.all().order_by('-usage_count')[:5]}
5959
return render(request, 'shortener/index.html', values)
60-

0 commit comments

Comments
 (0)