Skip to content

Commit f76ad12

Browse files
janicduplessisjanicduplessis
committed
Merge remote-tracking branch 'upstream/main' into @janic/rav-refactor-v2
2 parents 02fc6b0 + 44d3a4f commit f76ad12

File tree

466 files changed

+40027
-12319
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

466 files changed

+40027
-12319
lines changed

‎.eslintrc.changed.js

+28-4
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,46 @@ module.exports = {
77
rules: {
88
'deprecation/deprecation': 'error',
99
'rulesdir/no-default-id-values': 'error',
10+
'no-restricted-syntax': [
11+
'error',
12+
{
13+
selector: 'ImportNamespaceSpecifier[parent.source.value=/^@libs/]',
14+
message: 'Namespace imports from @libs are not allowed. Use named imports instead. Example: import { method } from "@libs/module"',
15+
},
16+
{
17+
selector: 'ImportNamespaceSpecifier[parent.source.value=/^@userActions/]',
18+
message: 'Namespace imports from @userActions are not allowed. Use named imports instead. Example: import { action } from "@userActions/module"',
19+
},
20+
],
1021
},
1122
overrides: [
1223
{
1324
files: [
1425
'src/libs/actions/IOU.ts',
1526
'src/libs/actions/Report.ts',
16-
'src/libs/actions/Task.ts',
17-
'src/libs/OptionsListUtils.ts',
18-
'src/libs/TransactionUtils/index.ts',
19-
'src/pages/home/ReportScreen.tsx',
2027
'src/pages/workspace/WorkspaceInitialPage.tsx',
2128
'src/pages/home/report/PureReportActionItem.tsx',
29+
'src/libs/SidebarUtils.ts',
2230
],
2331
rules: {
2432
'rulesdir/no-default-id-values': 'off',
2533
},
2634
},
35+
{
36+
files: ['**/libs/**/*.{ts,tsx}'],
37+
rules: {
38+
'no-restricted-syntax': [
39+
'error',
40+
{
41+
selector: 'ImportNamespaceSpecifier[parent.source.value=/^\\.\\./]',
42+
message: 'Namespace imports are not allowed. Use named imports instead. Example: import { method } from "../libs/module"',
43+
},
44+
{
45+
selector: 'ImportNamespaceSpecifier[parent.source.value=/^\\./]',
46+
message: 'Namespace imports are not allowed. Use named imports instead. Example: import { method } from "./libs/module"',
47+
},
48+
],
49+
},
50+
},
2751
],
2852
};

‎.github/actionlint.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
self-hosted-runner:
33
labels:
44
- ubuntu-latest-xl
5-
- macos-13-large
6-
- macos-13-xlarge
5+
- macos-15-large
6+
- macos-15-xlarge
77
- ubuntu-latest-reassure-tests
88
- macos-12

‎.github/actions/javascript/authorChecklist/index.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -17258,7 +17258,7 @@ const CONST = {
1725817258
},
1725917259
ACTIONS: {
1726017260
CREATED: 'created',
17261-
EDIT: 'edited',
17261+
EDITED: 'edited',
1726217262
},
1726317263
EVENTS: {
1726417264
ISSUE_COMMENT: 'issue_comment',
@@ -17277,6 +17277,8 @@ const CONST = {
1727717277
APP_REPO_URL: `https://github.com/${GIT_CONST.GITHUB_OWNER}/${GIT_CONST.APP_REPO}`,
1727817278
APP_REPO_GIT_URL: `[email protected]:${GIT_CONST.GITHUB_OWNER}/${GIT_CONST.APP_REPO}.git`,
1727917279
NO_ACTION: 'NO_ACTION',
17280+
ACTION_EDIT: 'ACTION_EDIT',
17281+
ACTION_REQUIRED: 'ACTION_REQUIRED',
1728017282
OPENAI_POLL_RATE: 1500,
1728117283
OPENAI_POLL_TIMEOUT: 90000,
1728217284
};
@@ -17568,7 +17570,9 @@ class GithubUtils {
1756817570
// eslint-disable-next-line max-len
1756917571
issueBody += `\r\n- [${isTimingDashboardChecked ? 'x' : ' '}] I checked the [App Timing Dashboard](https://graphs.expensify.com/grafana/d/yj2EobAGz/app-timing?orgId=1) and verified this release does not cause a noticeable performance regression.`;
1757017572
// eslint-disable-next-line max-len
17571-
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
17573+
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) for **this release version** and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
17574+
// eslint-disable-next-line max-len
17575+
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) for **the previous release version** and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
1757217576
// eslint-disable-next-line max-len
1757317577
issueBody += `\r\n- [${isGHStatusChecked ? 'x' : ' '}] I checked [GitHub Status](https://www.githubstatus.com/) and verified there is no reported incident with Actions.`;
1757417578
issueBody += '\r\n\r\ncc @Expensify/applauseleads\r\n';
@@ -17649,6 +17653,7 @@ class GithubUtils {
1764917653
/**
1765017654
* Get the most recent workflow run for the given New Expensify workflow.
1765117655
*/
17656+
/* eslint-disable rulesdir/no-default-id-values */
1765217657
static getLatestWorkflowRunID(workflow) {
1765317658
console.log(`Fetching New Expensify workflow runs for ${workflow}...`);
1765417659
return this.octokit.actions

‎.github/actions/javascript/awaitStagingDeploys/index.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -12262,7 +12262,7 @@ const CONST = {
1226212262
},
1226312263
ACTIONS: {
1226412264
CREATED: 'created',
12265-
EDIT: 'edited',
12265+
EDITED: 'edited',
1226612266
},
1226712267
EVENTS: {
1226812268
ISSUE_COMMENT: 'issue_comment',
@@ -12281,6 +12281,8 @@ const CONST = {
1228112281
APP_REPO_URL: `https://github.com/${GIT_CONST.GITHUB_OWNER}/${GIT_CONST.APP_REPO}`,
1228212282
APP_REPO_GIT_URL: `[email protected]:${GIT_CONST.GITHUB_OWNER}/${GIT_CONST.APP_REPO}.git`,
1228312283
NO_ACTION: 'NO_ACTION',
12284+
ACTION_EDIT: 'ACTION_EDIT',
12285+
ACTION_REQUIRED: 'ACTION_REQUIRED',
1228412286
OPENAI_POLL_RATE: 1500,
1228512287
OPENAI_POLL_TIMEOUT: 90000,
1228612288
};
@@ -12572,7 +12574,9 @@ class GithubUtils {
1257212574
// eslint-disable-next-line max-len
1257312575
issueBody += `\r\n- [${isTimingDashboardChecked ? 'x' : ' '}] I checked the [App Timing Dashboard](https://graphs.expensify.com/grafana/d/yj2EobAGz/app-timing?orgId=1) and verified this release does not cause a noticeable performance regression.`;
1257412576
// eslint-disable-next-line max-len
12575-
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
12577+
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) for **this release version** and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
12578+
// eslint-disable-next-line max-len
12579+
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) for **the previous release version** and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
1257612580
// eslint-disable-next-line max-len
1257712581
issueBody += `\r\n- [${isGHStatusChecked ? 'x' : ' '}] I checked [GitHub Status](https://www.githubstatus.com/) and verified there is no reported incident with Actions.`;
1257812582
issueBody += '\r\n\r\ncc @Expensify/applauseleads\r\n';
@@ -12653,6 +12657,7 @@ class GithubUtils {
1265312657
/**
1265412658
* Get the most recent workflow run for the given New Expensify workflow.
1265512659
*/
12660+
/* eslint-disable rulesdir/no-default-id-values */
1265612661
static getLatestWorkflowRunID(workflow) {
1265712662
console.log(`Fetching New Expensify workflow runs for ${workflow}...`);
1265812663
return this.octokit.actions

‎.github/actions/javascript/checkAndroidStatus/index.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -736655,7 +736655,7 @@ const CONST = {
736655736655
},
736656736656
ACTIONS: {
736657736657
CREATED: 'created',
736658-
EDIT: 'edited',
736658+
EDITED: 'edited',
736659736659
},
736660736660
EVENTS: {
736661736661
ISSUE_COMMENT: 'issue_comment',
@@ -736674,6 +736674,8 @@ const CONST = {
736674736674
APP_REPO_URL: `https://github.com/${GIT_CONST.GITHUB_OWNER}/${GIT_CONST.APP_REPO}`,
736675736675
APP_REPO_GIT_URL: `[email protected]:${GIT_CONST.GITHUB_OWNER}/${GIT_CONST.APP_REPO}.git`,
736676736676
NO_ACTION: 'NO_ACTION',
736677+
ACTION_EDIT: 'ACTION_EDIT',
736678+
ACTION_REQUIRED: 'ACTION_REQUIRED',
736677736679
OPENAI_POLL_RATE: 1500,
736678736680
OPENAI_POLL_TIMEOUT: 90000,
736679736681
};
@@ -736965,7 +736967,9 @@ class GithubUtils {
736965736967
// eslint-disable-next-line max-len
736966736968
issueBody += `\r\n- [${isTimingDashboardChecked ? 'x' : ' '}] I checked the [App Timing Dashboard](https://graphs.expensify.com/grafana/d/yj2EobAGz/app-timing?orgId=1) and verified this release does not cause a noticeable performance regression.`;
736967736969
// eslint-disable-next-line max-len
736968-
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
736970+
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) for **this release version** and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
736971+
// eslint-disable-next-line max-len
736972+
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) for **the previous release version** and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
736969736973
// eslint-disable-next-line max-len
736970736974
issueBody += `\r\n- [${isGHStatusChecked ? 'x' : ' '}] I checked [GitHub Status](https://www.githubstatus.com/) and verified there is no reported incident with Actions.`;
736971736975
issueBody += '\r\n\r\ncc @Expensify/applauseleads\r\n';
@@ -737046,6 +737050,7 @@ class GithubUtils {
737046737050
/**
737047737051
* Get the most recent workflow run for the given New Expensify workflow.
737048737052
*/
737053+
/* eslint-disable rulesdir/no-default-id-values */
737049737054
static getLatestWorkflowRunID(workflow) {
737050737055
console.log(`Fetching New Expensify workflow runs for ${workflow}...`);
737051737056
return this.octokit.actions

‎.github/actions/javascript/checkDeployBlockers/index.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -11545,7 +11545,7 @@ const CONST = {
1154511545
},
1154611546
ACTIONS: {
1154711547
CREATED: 'created',
11548-
EDIT: 'edited',
11548+
EDITED: 'edited',
1154911549
},
1155011550
EVENTS: {
1155111551
ISSUE_COMMENT: 'issue_comment',
@@ -11564,6 +11564,8 @@ const CONST = {
1156411564
APP_REPO_URL: `https://github.com/${GIT_CONST.GITHUB_OWNER}/${GIT_CONST.APP_REPO}`,
1156511565
APP_REPO_GIT_URL: `[email protected]:${GIT_CONST.GITHUB_OWNER}/${GIT_CONST.APP_REPO}.git`,
1156611566
NO_ACTION: 'NO_ACTION',
11567+
ACTION_EDIT: 'ACTION_EDIT',
11568+
ACTION_REQUIRED: 'ACTION_REQUIRED',
1156711569
OPENAI_POLL_RATE: 1500,
1156811570
OPENAI_POLL_TIMEOUT: 90000,
1156911571
};
@@ -11855,7 +11857,9 @@ class GithubUtils {
1185511857
// eslint-disable-next-line max-len
1185611858
issueBody += `\r\n- [${isTimingDashboardChecked ? 'x' : ' '}] I checked the [App Timing Dashboard](https://graphs.expensify.com/grafana/d/yj2EobAGz/app-timing?orgId=1) and verified this release does not cause a noticeable performance regression.`;
1185711859
// eslint-disable-next-line max-len
11858-
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
11860+
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) for **this release version** and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
11861+
// eslint-disable-next-line max-len
11862+
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) for **the previous release version** and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
1185911863
// eslint-disable-next-line max-len
1186011864
issueBody += `\r\n- [${isGHStatusChecked ? 'x' : ' '}] I checked [GitHub Status](https://www.githubstatus.com/) and verified there is no reported incident with Actions.`;
1186111865
issueBody += '\r\n\r\ncc @Expensify/applauseleads\r\n';
@@ -11936,6 +11940,7 @@ class GithubUtils {
1193611940
/**
1193711941
* Get the most recent workflow run for the given New Expensify workflow.
1193811942
*/
11943+
/* eslint-disable rulesdir/no-default-id-values */
1193911944
static getLatestWorkflowRunID(workflow) {
1194011945
console.log(`Fetching New Expensify workflow runs for ${workflow}...`);
1194111946
return this.octokit.actions

‎.github/actions/javascript/createOrUpdateStagingDeploy/index.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -11608,7 +11608,7 @@ const CONST = {
1160811608
},
1160911609
ACTIONS: {
1161011610
CREATED: 'created',
11611-
EDIT: 'edited',
11611+
EDITED: 'edited',
1161211612
},
1161311613
EVENTS: {
1161411614
ISSUE_COMMENT: 'issue_comment',
@@ -11627,6 +11627,8 @@ const CONST = {
1162711627
APP_REPO_URL: `https://github.com/${GIT_CONST.GITHUB_OWNER}/${GIT_CONST.APP_REPO}`,
1162811628
APP_REPO_GIT_URL: `[email protected]:${GIT_CONST.GITHUB_OWNER}/${GIT_CONST.APP_REPO}.git`,
1162911629
NO_ACTION: 'NO_ACTION',
11630+
ACTION_EDIT: 'ACTION_EDIT',
11631+
ACTION_REQUIRED: 'ACTION_REQUIRED',
1163011632
OPENAI_POLL_RATE: 1500,
1163111633
OPENAI_POLL_TIMEOUT: 90000,
1163211634
};
@@ -12137,7 +12139,9 @@ class GithubUtils {
1213712139
// eslint-disable-next-line max-len
1213812140
issueBody += `\r\n- [${isTimingDashboardChecked ? 'x' : ' '}] I checked the [App Timing Dashboard](https://graphs.expensify.com/grafana/d/yj2EobAGz/app-timing?orgId=1) and verified this release does not cause a noticeable performance regression.`;
1213912141
// eslint-disable-next-line max-len
12140-
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
12142+
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) for **this release version** and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
12143+
// eslint-disable-next-line max-len
12144+
issueBody += `\r\n- [${isFirebaseChecked ? 'x' : ' '}] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) for **the previous release version** and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).`;
1214112145
// eslint-disable-next-line max-len
1214212146
issueBody += `\r\n- [${isGHStatusChecked ? 'x' : ' '}] I checked [GitHub Status](https://www.githubstatus.com/) and verified there is no reported incident with Actions.`;
1214312147
issueBody += '\r\n\r\ncc @Expensify/applauseleads\r\n';
@@ -12218,6 +12222,7 @@ class GithubUtils {
1221812222
/**
1221912223
* Get the most recent workflow run for the given New Expensify workflow.
1222012224
*/
12225+
/* eslint-disable rulesdir/no-default-id-values */
1222112226
static getLatestWorkflowRunID(workflow) {
1222212227
console.log(`Fetching New Expensify workflow runs for ${workflow}...`);
1222312228
return this.octokit.actions

0 commit comments

Comments
 (0)