Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate icon does not work on MacOS, iOS, iPadOS #103

Open
alltheseas opened this issue Jun 27, 2023 · 11 comments
Open

Navigate icon does not work on MacOS, iOS, iPadOS #103

alltheseas opened this issue Jun 27, 2023 · 11 comments
Assignees
Labels
feature request Feature request ready for dev Ready to be worked on

Comments

@alltheseas
Copy link

Describe the bug
PWA
Safari iOS
Navigate does not work

To Reproduce

  1. go to Btcmap.org/map
  2. Tap navigate on any listed business

Expected behavior

Open up default navigation app on device (e.g. apple maps, google maps etc)

Screenshots
image

Additional context

@alltheseas alltheseas added the bug Something isn't working label Jun 27, 2023
@secondl1ght secondl1ght self-assigned this Jun 27, 2023
@secondl1ght
Copy link
Member

Hi @alltheseas thanks for the report, we use the geo URI link scheme to pass the location coordinates off to any compatible installed app on the device. I would have thought Apple Maps would recognise this standard but maybe they don't. Is that the maps app you are using?

@secondl1ght
Copy link
Member

Actually based on this error message it looks like Safari doesn't even try to pass the geo URI on to any other apps... classic Apple not using an open standard XD. Maybe for iOS users we should just use an Apple Maps link?

@alltheseas
Copy link
Author

Yes, seems like gmaps cannot be set as default on iOS, so apple maps link would be the safe bet.

https://www.alphr.com/set-google-maps-default-iphone/

@secondl1ght
Copy link
Member

Actually this is a Safari specific issue, so if a user was using Brave browser on iOS for example then the Navigate links would work. So maybe we should only default to Apple Maps if a user is using Safari...

@dadofsambonzuki
Copy link
Member

dadofsambonzuki commented Jun 27, 2023 via email

@alltheseas
Copy link
Author

Actually this is a Safari specific issue, so if a user was using Brave browser on iOS for example then the Navigate links would work. So maybe we should only default to Apple Maps if a user is using Safari...

Here is the brave browser behavior on iOS:

image

image

@secondl1ght
Copy link
Member

Thanks for testing - so it seems iOS in general doesn't support geo URI's (unless you need to specify a default application to open these types of links, but any mapping app you have on your phone should do this by default I would think). Do you have a Mac desktop we could also test on?

@alltheseas
Copy link
Author

alltheseas commented Jun 27, 2023

MacOS:

Firefox browser
-> Navigate does not do anything (no error message, nothing)
-> Share -> Navigate opens a new tab with e.g. geo:-29.8558861,31.0268087 that states "This address was not understood"
Screenshot 2023-06-27 at 4 06 07 PM

Safari browser
Navigate:
Screenshot 2023-06-27 at 4 07 02 PM
Share->Navigate
Screenshot 2023-06-27 at 4 07 23 PM

Brave browser has same behavior as Firefox browser
Screenshot 2023-06-27 at 4 08 22 PM

@alltheseas
Copy link
Author

Safari on iPadOS exhibits same behavior as MacOS

@secondl1ght
Copy link
Member

Entering the geo URI into the browser URL won't work - it works by if an application on your computer is listening for geo URI events coming from another application. But I think you've confirmed that it doesn't work on iOS or Mac, so we should use a regular Apple Maps or OpenStreetMap navigate URL for Apple users.

@alltheseas
Copy link
Author

alltheseas commented Jun 27, 2023

Entering the geo URI into the browser URL won't work

To be clear, I did not manually enter any URL. I simply clicked on the Navigate button.

I think you've confirmed that it doesn't work on iOS or Mac

Correct, and navigate does not work on the iPad either.

@alltheseas alltheseas changed the title Navigate icon does not work Navigate icon does not work on MacOS, iOS, iPadOS Jun 27, 2023
@secondl1ght secondl1ght added feature request Feature request ready for dev Ready to be worked on and removed bug Something isn't working labels Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request ready for dev Ready to be worked on
Projects
None yet
Development

No branches or pull requests

3 participants