Missing TclOOM() calls, which produce a panic when Tcl_InitStringRep() fails

Author: jan.nijtmans

generic/tclArithSeries.c

@@ -1192,6 +1192,8 @@ UpdateStringOfArithSeries(
      */
 
     p = srep = Tcl_InitStringRep(arithSeriesObjPtr, NULL, bytlen);
+    TclOOM(p, bytlen+1);
+
     if (!arithSeriesRepPtr->isDouble) {
 	for (i = 0; i < arithSeriesRepPtr->len; i++) {
 	    Tcl_WideInt d = ArithSeriesIndexInt(arithSeriesRepPtr, i);

generic/tclIndexObj.c

@@ -388,8 +388,9 @@ UpdateStringOfIndex(
 {
     IndexRep *indexRep = (IndexRep *)TclFetchInternalRep(objPtr, &tclIndexType)->twoPtrValue.ptr1;
     const char *indexStr = EXPAND_OF(indexRep);
+    size_t len = strlen(indexStr);
 
-    Tcl_InitStringRep(objPtr, indexStr, strlen(indexStr));
+    TclOOM(Tcl_InitStringRep(objPtr, indexStr, len), len+1);
 }
 
 /*

generic/tclTestABSList.c

@@ -1047,7 +1047,7 @@ UpdateStringOfLgen(Tcl_Obj *objPtr)
     LgenSeries *lgenSeriesRepPtr;
     Tcl_Obj *element;
     Tcl_Size i;
-    size_t bytlen;
+    Tcl_Size bytlen;
     Tcl_Obj *tmpstr = Tcl_NewObj();
 
     lgenSeriesRepPtr = (LgenSeries*)objPtr->internalRep.twoPtrValue.ptr1;
@@ -1062,8 +1062,9 @@ UpdateStringOfLgen(Tcl_Obj *objPtr)
 	}
     }
 
-    bytlen = Tcl_GetCharLength(tmpstr);
-    Tcl_InitStringRep(objPtr, Tcl_GetString(tmpstr), bytlen);
+    char *str = Tcl_GetStringFromObj(tmpstr, &bytlen);
+
+    TclOOM(Tcl_InitStringRep(objPtr, str, bytlen), bytlen+1);
     Tcl_DecrRefCount(tmpstr);
 
     return;

macosx/tclMacOSXFCmd.c

@@ -687,7 +687,7 @@ UpdateStringOfOSType(
     Tcl_Encoding encoding;
     char src[5];
 
-    TclOOM(dst, size);
+    TclOOM(dst, size+1);
 
     src[0] = (char) (osType >> 24);
     src[1] = (char) (osType >> 16);