Add tests for resolution order of async modules promises #4591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Oct 1, 2025
| Promise.all([pA_start.promise, pB_start.promise]).then(p1.reject); | ||
|
|
||
| importsP.then(() => { | ||
| assert.compareArray(logs, ["B", "A"]); |
There was a problem hiding this comment.
Before the normative change, this would be A,B.
nicolo-ribaudo
force-pushed
the
async-mod-eval-prom-settl-ord
branch
from
18d23ef to
644a304
Compare
|
Mhhh there might be something wrong with the test, I was expecting V8 and SM to fail it. |
nicolo-ribaudo
force-pushed
the
async-mod-eval-prom-settl-ord
branch
from
644a304 to
697229d
Compare
|
Results are (almost) as expected:
|
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Oct 3, 2025
…der r=jonco This patch inverts the order in which we reject promises in AsyncModuleExecutionRejected to match AsyncModuleExecutionFulfilled: first the promise corresponding to the leaf module (the one that throws) is rejected, and then its ancestors. This change was discussed at the July 2025 TC39 meeting. Spec PR: tc39/ecma262#3695 test262: tc39/test262#4591 Differential Revision: https://phabricator.services.mozilla.com/D267210
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Oct 7, 2025
…der r=jonco This patch inverts the order in which we reject promises in AsyncModuleExecutionRejected to match AsyncModuleExecutionFulfilled: first the promise corresponding to the leaf module (the one that throws) is rejected, and then its ancestors. This change was discussed at the July 2025 TC39 meeting. Spec PR: tc39/ecma262#3695 test262: tc39/test262#4591 Differential Revision: https://phabricator.services.mozilla.com/D267210
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 8, 2025
…der r=jonco This patch inverts the order in which we reject promises in AsyncModuleExecutionRejected to match AsyncModuleExecutionFulfilled: first the promise corresponding to the leaf module (the one that throws) is rejected, and then its ancestors. This change was discussed at the July 2025 TC39 meeting. Spec PR: tc39/ecma262#3695 test262: tc39/test262#4591 Differential Revision: https://phabricator.services.mozilla.com/D267210 UltraBlame original commit: a3cf4d1eef17209c4c4194e07f38fe870c417781
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 8, 2025
…der r=jonco This patch inverts the order in which we reject promises in AsyncModuleExecutionRejected to match AsyncModuleExecutionFulfilled: first the promise corresponding to the leaf module (the one that throws) is rejected, and then its ancestors. This change was discussed at the July 2025 TC39 meeting. Spec PR: tc39/ecma262#3695 test262: tc39/test262#4591 Differential Revision: https://phabricator.services.mozilla.com/D267210 UltraBlame original commit: a3cf4d1eef17209c4c4194e07f38fe870c417781
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 8, 2025
…der r=jonco This patch inverts the order in which we reject promises in AsyncModuleExecutionRejected to match AsyncModuleExecutionFulfilled: first the promise corresponding to the leaf module (the one that throws) is rejected, and then its ancestors. This change was discussed at the July 2025 TC39 meeting. Spec PR: tc39/ecma262#3695 test262: tc39/test262#4591 Differential Revision: https://phabricator.services.mozilla.com/D267210 UltraBlame original commit: a3cf4d1eef17209c4c4194e07f38fe870c417781
Co-authored-by: Ms2ger <[email protected]>
Ms2ger
force-pushed
the
async-mod-eval-prom-settl-ord
branch
from
58e2e96 to
314fd06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for tc39/ecma262#3695