Skip to content

Commit 4c69606

Browse files
fix issue of pie chart being invisible when total group value is 0
1 parent 20f3b04 commit 4c69606

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

dc.css

+9
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,15 @@ div.dc-chart {
2626
fill: #ccc;
2727
}
2828

29+
.dc-chart .empty-chart .pie-slice path {
30+
fill: #FFEEEE;
31+
cursor: default;
32+
}
33+
34+
.dc-chart .empty-chart .pie-slice {
35+
cursor: default;
36+
}
37+
2938
.dc-chart .pie-slice {
3039
fill: white;
3140
font-size: 12px;

src/pie-chart.js

+10-1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ dc.pieChart = function (parent, chartGroup) {
3737
var DEFAULT_MIN_ANGLE_FOR_LABEL = 0.5;
3838

3939
var _sliceCssClass = "pie-slice";
40+
var _emptyCssClass = "empty-chart";
4041

4142
var _radius,
4243
_innerRadius = 0;
@@ -91,6 +92,13 @@ dc.pieChart = function (parent, chartGroup) {
9192
var pieData = pie(_chart.data());
9293

9394
if (_g) {
95+
if(Number.isNaN(pieData[pieData.length-1].endAngle)) {
96+
pieData = pie([{key:"empty",value:1}]);
97+
_g.attr("class",_emptyCssClass);
98+
} else {
99+
_g.attr("class","");
100+
}
101+
94102
var slices = _g.selectAll("g." + _sliceCssClass)
95103
.data(pieData);
96104

@@ -336,7 +344,8 @@ dc.pieChart = function (parent, chartGroup) {
336344
}
337345

338346
function onClick(d, i) {
339-
_chart.onClick(d.data, i);
347+
if (_g.attr("class") != _emptyCssClass)
348+
_chart.onClick(d.data, i);
340349
}
341350

342351
function safeArc(d, i, arc) {

0 commit comments

Comments
 (0)