Skip to content

Commit 90126e7

Browse files
committed
fix(vcs): remove empty string from command in repo.get_tracked_files()
The test should be exercising this code path, so I'm not really sure why it passes in Taskgraph but failed in another case in CI. Maybe it's related to the version of Git on the worker.
1 parent 25ce307 commit 90126e7

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/taskgraph/util/vcs.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,10 @@ def _files_template(self, diff_filter):
291291

292292
def get_tracked_files(self, *paths, rev=None):
293293
rev = rev or "."
294-
return self.run("files", "-r", rev, *paths).splitlines()
294+
cmd = ["files", "-r", rev]
295+
if paths:
296+
cmd.extend(paths)
297+
return self.run(*cmd).splitlines()
295298

296299
def get_changed_files(self, diff_filter=None, mode=None, rev=None, base_rev=None):
297300
diff_filter = diff_filter or "ADM"
@@ -477,7 +480,10 @@ def get_commit_message(self, revision=None):
477480

478481
def get_tracked_files(self, *paths, rev=None):
479482
rev = rev or "HEAD"
480-
return self.run("ls-tree", "-r", "--name-only", rev, *paths).splitlines()
483+
cmd = ["ls-tree", "-r", "--name-only", rev]
484+
if paths:
485+
cmd.extend(paths)
486+
return self.run(*cmd).splitlines()
481487

482488
def get_changed_files(self, diff_filter=None, mode=None, rev=None, base_rev=None):
483489
diff_filter = diff_filter or "ADM"

0 commit comments

Comments
 (0)