Skip to content

Incomplete space/index iterator documentation #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remagister opened this issue May 1, 2019 · 8 comments
Open

Incomplete space/index iterator documentation #766

remagister opened this issue May 1, 2019 · 8 comments
Assignees
Labels
add details [nature] More details needed, some info missing. Documentation is incomplete. reference [location] Tarantool manual, Reference part server [area] Task relates to Tarantool's server (core) functionality

Comments

@remagister
Copy link

remagister commented May 1, 2019

Motivation
Methods space.pairs and index.pairs return an iterator that might be used with for-in loop, as stated in documentation. However there is no information about the structure and origin of the provided iterator (in both en and ru versions).

Suggestion
Please insert links to the luafun documentation, that describe iterator structure, iterator_mt metatable functions or at least mention that luafun methods are available to use.

@lenkis lenkis added 1.10 feature A new functionality reference [location] Tarantool manual, Reference part server [area] Task relates to Tarantool's server (core) functionality labels May 13, 2019
@Totktonada
Copy link
Member

@pgulutzan I hope a user want to know about methods (s)he can use on this iterator object, not about luafun internals. I think that a sentence that :pairs() returns luafun iterator and the link to the luafun documentation ( https://luafun.github.io/index.html ) is enough.

@Totktonada Totktonada reopened this May 24, 2019
@pgulutzan
Copy link
Contributor

So what's the issue here?
You're objecting that the manual should not point to https://luafun.github.io/under_the_hood.html
and saying it should point to https://luafun.github.io/index.html?

@pgulutzan pgulutzan added the need feedback [special status] On hold, awaiting feedback label May 24, 2019
@Totktonada
Copy link
Member

Yep, I think so.

@pgulutzan
Copy link
Contributor

Okay.

@Totktonada
Copy link
Member

Totktonada commented Apr 10, 2022

For information about iterators’ internal structures see the [“Lua Functional library”(https://luafun.github.io/index.html) documentation.

We again meet the situation, when a user highlights that he is unable to find a luafun method in the documentation. I propose:

  1. Change the link description. It is not about internal structures, it is about user's API.
  2. Add a table with luafun methods to at least make it searchable.

The pages of the topic:

https://www.tarantool.io/en/doc/latest/reference/reference_lua/box_space/pairs/
https://www.tarantool.io/en/doc/latest/reference/reference_lua/box_index/pairs/

@Totktonada Totktonada reopened this Apr 10, 2022
@patiencedaur patiencedaur added add details [nature] More details needed, some info missing. Documentation is incomplete. and removed feature A new functionality need feedback [special status] On hold, awaiting feedback 1.10 labels Apr 11, 2022
@veod32 veod32 added this to the Estimate [@veod32] milestone Apr 25, 2022
@patiencedaur
Copy link
Contributor

The task looks very similar to #2863 and other tables the developers added for connectors. @Totktonada, I'm appending the dev tag, feel free to delete it if you believe it's not a task for you and your team.

@patiencedaur patiencedaur added the dev To be updated by the developers. Includes developer guidelines and many API elements. label May 20, 2022
@Totktonada Totktonada self-assigned this May 20, 2022
@veod32
Copy link
Collaborator

veod32 commented Jun 20, 2022

@Totktonada There're 80+ functions there https://luafun.github.io/genindex.html
Does it make sense to bring this list into our documentation, what about further support of the list? Or is it one time action because nothing is going to change critically in the luafun library in the future?

@veod32 veod32 removed this from the Estimate [@veod32] milestone Jun 20, 2022
@Totktonada
Copy link
Member

@veod32 luafun changes rarely. I don't think it will be a problem.

@TarantoolBot TarantoolBot removed the teamL label Jun 7, 2023
@andreyaksenov andreyaksenov removed the dev To be updated by the developers. Includes developer guidelines and many API elements. label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add details [nature] More details needed, some info missing. Documentation is incomplete. reference [location] Tarantool manual, Reference part server [area] Task relates to Tarantool's server (core) functionality
Projects
None yet
Development

No branches or pull requests

8 participants