Skip to content

Possible misleading typo in 22-24 Decorators #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benkawecki opened this issue Oct 30, 2018 · 1 comment
Closed

Possible misleading typo in 22-24 Decorators #25

benkawecki opened this issue Oct 30, 2018 · 1 comment

Comments

@benkawecki
Copy link

benkawecki commented Oct 30, 2018

In 100daysofcode-with-python-course/days/22-24-decorators/decorators.ipynb under "Second day: a practical exercise" you list the following block of code:

@make_html('p')
@make_html('strong')
def get_text(text):
    pass

As the problem is listed now it implies that make_html decorator should be responsible for printing the test instead of just adding tags. In the linked pybite get_text() is defined as:

def get_text(text):
    print(text)

Is that pass in the jupyter notebook a typo, which instead should be print(text)?

@benkawecki benkawecki changed the title Possible misleading type in 22-24 Decorators Possible misleading typo in 22-24 Decorators Oct 30, 2018
@bbelderbos
Copy link
Collaborator

Hey @benkawecki I agree, print(text) would be better/clearer. I updated the notebook. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants