-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
button.namespace.onTap ... #9
Comments
Nice advice! |
@Pircate had gave us the detailed implementation at #13 . But lately I'd changed my mind of the comment above. In short, the namespace style is cool, but seems to resolve no problem. May Some beginners think that the extensions created by ActionClosurable are official interface? In addition, extending I'm afraid that introducing a namespace might cause to more complex interface. |
You can still create factory method like
Library users can do that, but IMO library authors should avoid the namespace pollution as much as they could. In addition ...
Just wanted to make it clear that my point was not about "cool or not" or "natural or not". Of course this library is not 1000 or 10000 star library, I understand if you can keep it as is.👌 Thoughts? 🤔 |
onTap should live on separated namespace to avoid potential conflict with other library.
e.g.
button.rx.event
The text was updated successfully, but these errors were encountered: