more

Author: dantaik

packages/protocol/contracts/shared/tokenvault/ERC1155Vault.sol

@@ -73,7 +73,6 @@ contract ERC1155Vault is BaseNFTVault, ERC1155ReceiverUpgradeable {
         // Send the message and obtain the message hash
         bytes32 msgHash;
 
-        // TODO(daniel): replace with immutable
         (msgHash, message_) =
             IBridge(resolve(LibStrings.B_BRIDGE, false)).sendMessage{ value: msg.value }(message);
 
@@ -297,7 +296,6 @@ contract ERC1155Vault is BaseNFTVault, ERC1155ReceiverUpgradeable {
             (owner(), _ctoken.addr, _ctoken.chainId, _ctoken.symbol, _ctoken.name)
         );
 
-        // TODO(daniel): replace with immutable
         btoken_ = address(new ERC1967Proxy(resolve(LibStrings.B_BRIDGED_ERC1155, false), data));
 
         bridgedToCanonical[btoken_] = _ctoken;

packages/protocol/contracts/shared/tokenvault/ERC20Vault.sol

@@ -297,7 +297,6 @@ contract ERC20Vault is BaseVault {
             }
         }
 
-        // TODO(daniel): replace with immutable
         address bridge = resolve(LibStrings.B_BRIDGE, false);
 
         (
@@ -609,7 +608,6 @@ contract ERC20Vault is BaseVault {
             (owner(), ctoken.addr, ctoken.chainId, ctoken.decimals, ctoken.symbol, ctoken.name)
         );
 
-        // TODO(daniel): replace with immutable
         btoken = address(new ERC1967Proxy(resolve(LibStrings.B_BRIDGED_ERC20, false), data));
         bridgedToCanonical[btoken] = ctoken;
         canonicalToBridged[ctoken.chainId][ctoken.addr] = btoken;
@@ -627,7 +625,6 @@ contract ERC20Vault is BaseVault {
     function _consumeTokenQuota(address _token, uint256 _amount) private {
         address quotaManager = resolve(LibStrings.B_QUOTA_MANAGER, true);
         if (quotaManager != address(0)) {
-            // TODO(daniel): replace with immutable
             IQuotaManager(quotaManager).consumeQuota(_token, _amount);
         }
     }

packages/protocol/contracts/shared/tokenvault/ERC721Vault.sol

@@ -70,8 +70,7 @@ contract ERC721Vault is BaseNFTVault, IERC721Receiver {
 
         bytes32 msgHash;
         (msgHash, message_) =
-        // TODO(daniel): replace with immutable
-         IBridge(resolve(LibStrings.B_BRIDGE, false)).sendMessage{ value: msg.value }(message);
+            IBridge(resolve(LibStrings.B_BRIDGE, false)).sendMessage{ value: msg.value }(message);
 
         emit TokenSent({
             msgHash: msgHash,
@@ -254,7 +253,6 @@ contract ERC721Vault is BaseNFTVault, IERC721Receiver {
             (owner(), _ctoken.addr, _ctoken.chainId, _ctoken.symbol, _ctoken.name)
         );
 
-        // TODO(daniel): replace with immutable
         btoken_ = address(new ERC1967Proxy(resolve(LibStrings.B_BRIDGED_ERC721, false), data));
         bridgedToCanonical[btoken_] = _ctoken;
         canonicalToBridged[_ctoken.chainId][_ctoken.addr] = btoken_;