change return type of write_serializable_content

Author: Rémi Labeyrie

src/errors.rs

@@ -43,8 +43,6 @@ pub enum Error {
     EscapeError(EscapeError),
     /// Specified namespace prefix is unknown, cannot resolve namespace for it
     UnknownPrefix(Vec<u8>),
-    /// Serialization error
-    NonSerializable(String),
 }
 
 impl From<IoError> for Error {
@@ -118,7 +116,6 @@ impl fmt::Display for Error {
                 write_byte_string(f, prefix)?;
                 f.write_str("'")
             }
-            Error::NonSerializable(e) => write!(f, "error while serializing value: {e}"),
         }
     }
 }

src/writer.rs

@@ -2,9 +2,6 @@
 
 use std::io::Write;
 
-#[cfg(feature = "serialize")]
-use serde::Serialize;
-
 use crate::encoding::UTF8_BOM;
 use crate::errors::Result;
 use crate::events::{attributes::Attribute, BytesCData, BytesStart, BytesText, Event};
@@ -13,6 +10,10 @@ use crate::events::{attributes::Attribute, BytesCData, BytesStart, BytesText, Ev
 mod async_tokio;
 
 /// XML writer. Writes XML [`Event`]s to a [`std::io::Write`] or [`tokio::io::AsyncWrite`] implementor.
+#[cfg(feature = "serialize")]
+use {crate::de::DeError, serde::Serialize};
+
+/// XML writer. Writes XML [`Event`]s to a [`std::io::Write`] implementor.
 ///
 /// # Examples
 ///
@@ -346,7 +347,10 @@ impl<'a, W: Write> ElementWriter<'a, W> {
 
     /// Serialize an arbitrary value inside the current element
     #[cfg(feature = "serialize")]
-    pub fn write_serializable_content<T: Serialize>(self, content: T) -> Result<&'a mut Writer<W>> {
+    pub fn write_serializable_content<T: Serialize>(
+        self,
+        content: T,
+    ) -> std::result::Result<&'a mut Writer<W>, DeError> {
         use crate::se::Serializer;
 
         self.writer
@@ -364,9 +368,7 @@ impl<'a, W: Write> ElementWriter<'a, W> {
             );
         }
 
-        if let Err(error) = content.serialize(serializer) {
-            return Err(Error::NonSerializable(error.to_string()));
-        }
+        content.serialize(serializer)?;
 
         self.writer
             .write_event(Event::End(self.start_tag.to_end()))?;