Rename BytesCData::from_str to BytesCData::new and change it to accept Cow<str>

Author: Mingun

Changelog.md

@@ -147,6 +147,12 @@
 - [#428]: Removed `Decoder` parameter from `_and_decode` versions of functions for
   `BytesText` (remember, that those functions was renamed in #415).
 
+- [#431]: Changed event constructors:
+  |Old names                                         |New name
+  |--------------------------------------------------|----------------------------------------------
+  |`BytesCData::new(impl Into<Cow<[u8]>>)`           |`BytesCData::new(impl Into<Cow<str>>)`
+  |`BytesCData::from_str(&str)`                      |_(as above)_
+
 ### New Tests
 
 - [#9]: Added tests for incorrect nested tags in input
@@ -177,6 +183,7 @@
 [#421]: https://github.com/tafia/quick-xml/pull/421
 [#423]: https://github.com/tafia/quick-xml/pull/423
 [#428]: https://github.com/tafia/quick-xml/pull/428
+[#431]: https://github.com/tafia/quick-xml/pull/431
 
 ## 0.23.0 -- 2022-05-08
 

src/de/mod.rs

@@ -1305,10 +1305,7 @@ mod tests {
             de.next().unwrap(),
             Start(BytesStart::borrowed(r#"tag a="2""#, 3))
         );
-        assert_eq!(
-            de.next().unwrap(),
-            CData(BytesCData::from_str("cdata content"))
-        );
+        assert_eq!(de.next().unwrap(), CData(BytesCData::new("cdata content")));
         assert_eq!(de.next().unwrap(), End(BytesEnd::borrowed("tag")));
 
         assert_eq!(

src/events/mod.rs

@@ -855,8 +855,8 @@ impl<'a> BytesCData<'a> {
 
     /// Creates a new `BytesCData` from a string
     #[inline]
-    pub fn from_str(content: &'a str) -> Self {
-        Self::wrap(content.as_bytes(), Decoder::utf8())
+    pub fn new<C: Into<Cow<'a, str>>>(content: C) -> Self {
+        Self::wrap(str_cow_to_bytes(content), Decoder::utf8())
     }
 
     /// Ensures that all data is owned to extend the object's lifetime if
@@ -1102,6 +1102,14 @@ impl<'a> AsRef<Event<'a>> for Event<'a> {
 
 ////////////////////////////////////////////////////////////////////////////////////////////////////
 
+#[inline]
+fn str_cow_to_bytes<'a, C: Into<Cow<'a, str>>>(content: C) -> Cow<'a, [u8]> {
+    match content.into() {
+        Cow::Borrowed(s) => Cow::Borrowed(s.as_bytes()),
+        Cow::Owned(s) => Cow::Owned(s.into_bytes()),
+    }
+}
+
 #[cfg(test)]
 mod test {
     use super::*;

src/reader.rs

@@ -2666,7 +2666,7 @@ mod test {
 
                     assert_eq!(
                         reader.read_event_impl($buf).unwrap(),
-                        Event::CData(BytesCData::from_str(""))
+                        Event::CData(BytesCData::new(""))
                     );
                 }