Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs stretch to full width of screen in landscape view #6

Open
jvoll opened this issue Nov 17, 2011 · 2 comments
Open

Dialogs stretch to full width of screen in landscape view #6

jvoll opened this issue Nov 17, 2011 · 2 comments

Comments

@jvoll
Copy link
Member

jvoll commented Nov 17, 2011

To reproduce open a dialog (most offensive looking one is the login dialog) and flip the screen to landscape mode. I'm not sure exactly how to make this look its best, however I'm thinking that just by not stretching the dialog to the full width of the screen in landscape mode will help a lot.

@ahal
Copy link
Member

ahal commented Feb 23, 2012

This is because in styles.xml we define:

<!-- Dialog Controls -->    
<style name="DialogControl" parent="@style/BaseView">
    <item name="android:layout_alignParentRight">true</item>
    <item name="android:layout_centerVertical">true</item>
    <item name="android:layout_marginRight">30dp</item>
</style>

<style name="DialogLabel" parent="@style/BaseView">
    <item name="android:layout_centerVertical">true</item>
    <item name="android:layout_alignParentLeft">true</item>
    <item name="android:layout_marginLeft">30dp</item>
</style>

We have an element set to go to the far right and another set to go to the far left. Instead we should put the label at the far left and make the control relative to the label.

@jvoll
Copy link
Member Author

jvoll commented Mar 11, 2012

This also applies to portrait view for the login dialog. I've tried fixing this and failed...for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants