Fix: Adds a missing corner case for conditional splitting

Author: ruiconti

kingdom/access/dsl.py

@@ -35,7 +35,7 @@
 
 def conditionals_split(sequence: str):
     expressions = sequence.split("||")
-    if "" in expressions:
+    if "" in expressions or " " in expressions:
         # meaning that we had a loose OR
         return False
 

kingdom/access/tests/test_dsl.py

@@ -11,14 +11,17 @@
 
 def test_conditionals_split():
     input = [
-        "expr || newexpr",
-        "expr||newexpr",
-        "  expr || newexpr    ",
-        "expr|newexpr",
-        "expr   || newexpr||neewexpr||",
-        "ex pr   || new expr ||  ",
-        "  expr ||| newexpr    ",
-        "  expr|||newexpr    ",
+        "expr || newexpr",  # valid
+        "expr||newexpr",  # valid
+        "  expr || newexpr    ",  # valid
+        "  expr || ",  # invalid
+        " ||  expr ",  # invalid
+        " ||  expr || ",  # invalid
+        "expr|newexpr",  # invalid
+        "expr   || newexpr||neewexpr||",  # invalid
+        "ex pr   || new expr ||  ",  # invalid
+        "  expr ||| newexpr    ",  # invalid
+        "  expr|||newexpr    ",  # invalid
     ]
 
     want = [
@@ -30,6 +33,9 @@ def test_conditionals_split():
         False,
         False,
         False,
+        False,
+        False,
+        False,
     ]
 
     got = [conditionals_split(sequence) for sequence in input]