Skip to content

Commit 938b0a7

Browse files
committed
scripts: Version EC separately from SBIOS
The original rationale for having the EC version match the SBIOS version was to ensure that compatible versions of each were installed. So we set the EC version to the SBIOS version and always flash both of them, even if only one actually changed. At some point, a mechanism should be implemented that checks for a minimum supported/compatible version. This would be comparable to the LVFS MetaInfo's "requires" field. Ref: f4f4d5b ("Build EC as a submodule, specifying version") Signed-off-by: Tim Crawford <[email protected]>
1 parent aa32ba2 commit 938b0a7

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

scripts/_build/ec.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,5 @@ done < "$1"
1818
BUILD_DIR="build"
1919

2020
make -C ec BUILD="$BUILD_DIR" clean
21-
make -C ec VERSION="${VERSION}" "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
21+
make -C ec "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
2222
cp "ec/$BUILD_DIR/ec.rom" "$2"

scripts/build.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,7 @@ KERNELVERSION="${VERSION}" \
8686
# Rebuild EC firmware for System76 EC models
8787
if [ ! -e "${MODEL_DIR}/ec.rom" -a -e "${MODEL_DIR}/ec.config" ]
8888
then
89-
env VERSION="${VERSION}" \
90-
./scripts/_build/ec.sh \
89+
./scripts/_build/ec.sh \
9190
"${MODEL_DIR}/ec.config" \
9291
"${BUILD}/ec.rom"
9392
fi

0 commit comments

Comments
 (0)