Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update promise and resource status condition when delete workflow is triggered #413

Open
richcooper95 opened this issue Mar 6, 2025 · 0 comments

Comments

@richcooper95
Copy link
Member

Summary

In #362 we added a DeleteWorkflowCompletedCondition which is (1) currently only used on Resources, and (2) is only updated on Resource Delete workflow failures.

This issue is to address (2) by updating the condition to communicate that a Delete workflow has started, for both Promises and Resources.

[#412 addresses (1) by adding the condition to the Promise status too!]

Details

See #362 for how the condition is used in the failure case. We should update the condition to the following when a Delete workflow has started:

    Last Transition Time:                   2025-03-06T14:48:07Z
    Message:                                Delete Pipeline pipeline-1 is running
    Reason:                                 DeleteWorkflowInProgress
    Status:                                 False
    Type:                                   DeleteWorkflowCompleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant