Skip to content

Commit 0cd2c7c

Browse files
author
pipeline
committed
v18.4.49 is released
1 parent 2bbbf9e commit 0cd2c7c

File tree

104 files changed

+1804
-248
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

104 files changed

+1804
-248
lines changed

controls/calendars/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@syncfusion/ej2-calendars",
3-
"version": "18.4.43",
3+
"version": "18.4.48",
44
"description": "A complete package of date or time components with built-in features such as date formatting, inline editing, multiple (range) selection, range restriction, month and year selection, strict mode, and globalization.",
55
"author": "Syncfusion Inc.",
66
"license": "SEE LICENSE IN license",

controls/charts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@syncfusion/ej2-charts",
3-
"version": "18.4.47",
3+
"version": "18.4.48",
44
"description": "Feature-rich chart control with built-in support for over 25 chart types, technical indictors, trendline, zooming, tooltip, selection, crosshair and trackball.",
55
"author": "Syncfusion Inc.",
66
"license": "SEE LICENSE IN license",

controls/charts/spec/chart/legend/legend.spec.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -738,13 +738,14 @@ describe('Chart Legend', () => {
738738
legendElement = document.getElementById(legendId + '_text_' + 4);
739739
trigger.clickEvent(legendElement);
740740
selectedElement = document.getElementsByClassName(selection + 4);
741-
expect(selectedElement.length).toBe(0);
741+
expect(selectedElement.length).toBe(1);
742742
legendElement = document.getElementById(legendId + '_text_' + 1);
743743
trigger.clickEvent(legendElement);
744744
selectedElement = document.getElementsByClassName(selection + 1);
745-
expect(selectedElement.length).toBe(0);
745+
expect(selectedElement.length).toBe(1);
746746
done();
747747
};
748+
chartObj.legendSettings.toggleVisibility = false;
748749
chartObj.selectionMode = 'Point';
749750
chartObj.isMultiSelect = true;
750751
for (let series of chartObj.series) {
@@ -1871,4 +1872,4 @@ describe('Chart Legend', () => {
18711872
//Check the final memory usage against the first usage, there should be little change if everything was properly deallocated
18721873
expect(memory).toBeLessThan(profile.samples[0] + 0.25);
18731874
})
1874-
});
1875+
});

controls/charts/src/chart/chart.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1370,6 +1370,8 @@ export class Chart extends Component<HTMLElement> implements INotifyPropertyChan
13701370
public svgId: string;
13711371
/** @private */
13721372
public isBlazor: boolean;
1373+
/** @private */
1374+
public isRedrawSelection: boolean;
13731375
/**
13741376
* Touch object to unwire the touch event from element
13751377
*/

controls/charts/src/chart/user-interaction/selection.ts

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -315,11 +315,11 @@ export class Selection extends BaseSelection {
315315
*/
316316
public performSelection(index: Index, chart: Chart, element?: Element): void {
317317
this.isSeriesMode = this.currentMode === 'Series';
318-
if (chart.series[index.series].type === 'BoxAndWhisker' &&
318+
if (chart.series[index.series].type === 'BoxAndWhisker' && element &&
319319
element.id === chart.element.id + '_Series_' + index.series + '_Point_' + index.point + '_BoxPath') {
320320
element = <Element>element.parentNode;
321321
}
322-
if (chart.series[index.series].type === 'Area' && (this.currentMode === 'Point' || this.currentMode === 'Cluster') &&
322+
if (chart.series[index.series].type === 'Area' && (this.currentMode === 'Point' || this.currentMode === 'Cluster') && element &&
323323
(element.id === this.chart.element.id + '_Series_' + index.series)) {
324324
let className: string = this.generateStyle(chart.series[index.series]);
325325
let selectionEle: NodeListOf<HTMLElement> = document.querySelectorAll('.' + className);
@@ -333,7 +333,7 @@ export class Selection extends BaseSelection {
333333
this.blurEffect(chart.element.id, chart.visibleSeries);
334334
break;
335335
case 'Point':
336-
if (!isNaN(index.point)) {
336+
if (!isNaN(index.point) && element) {
337337
this.selection(chart, index, [element]);
338338
this.selectionComplete(chart, index, this.currentMode);
339339
this.blurEffect(chart.element.id, chart.visibleSeries);
@@ -639,6 +639,13 @@ export class Selection extends BaseSelection {
639639
*/
640640
public redrawSelection(chart: Chart, oldMode: SelectionMode | HighlightMode): void {
641641
this.isSeriesMode = oldMode === 'Series';
642+
if (!isNullOrUndefined(oldMode)) {
643+
if (oldMode.indexOf('Drag') !== -1 || oldMode === 'Lasso') {
644+
chart.isRedrawSelection = false;
645+
} else {
646+
chart.isRedrawSelection = true;
647+
}
648+
}
642649
let selectedDataIndexes: Indexes[] = <Indexes[]>extend([], this.selectedDataIndexes, null, true);
643650
let highlightDataIndexes: Indexes[] = <Indexes[]>extend([], this.highlightDataIndexes, null, true);
644651
if (this.styleId.indexOf('highlight') > 0 && highlightDataIndexes.length > 0 ) {
@@ -1156,7 +1163,7 @@ export class Selection extends BaseSelection {
11561163
}
11571164
}
11581165
private removeSelectedElements(chart: Chart, index: Index[], seriesCollection: SeriesModel[]): void {
1159-
index.splice(0, index.length);
1166+
index = chart.isRedrawSelection ? index : index.splice(0, index.length); // No need to remove selected indexes while redrawing
11601167
let seriesElements: Element[];
11611168
for (let series of seriesCollection) {
11621169
seriesElements = this.getSeriesElements(series);

controls/charts/src/common/model/theme.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ export function getThemeColor(theme: ChartTheme | AccumulationTheme): IThemeStyl
197197
break;
198198
case 'Bootstrap4':
199199
style = {
200-
axisLabel: '#212529', axisTitle: '#ffffff', axisLine: '#CED4DA', majorGridLine: '#CED4DA',
200+
axisLabel: '#212529', axisTitle: '#212529', axisLine: '#CED4DA', majorGridLine: '#CED4DA',
201201
minorGridLine: '#DEE2E6', majorTickLine: '#ADB5BD', minorTickLine: '#CED4DA', chartTitle: '#212529', legendLabel: '#212529',
202202
background: '#FFFFFF', areaBorder: '#DEE2E6', errorBar: '#000000', crosshairLine: '#6C757D', crosshairFill: '#495057',
203203
crosshairLabel: '#FFFFFF', tooltipFill: 'rgba(0, 0, 0, 0.9)', tooltipBoldLabel: 'rgba(255,255,255)',

controls/compression/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## [Unreleased]
44

5-
## 18.4.48 (2021-03-16)
5+
## 18.4.49 (2021-03-23)
66

77
### Compression
88

controls/data/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## [Unreleased]
44

5-
## 18.4.48 (2021-03-16)
5+
## 18.4.49 (2021-03-23)
66

77
### DataManager
88

controls/diagrams/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
- `#316472` - This issue "Strange snapping behaviors with swimlane " has been fixed.
1212
- `#317149` - This issue "Exception occurs when drag and drop a lane on connector in swimlane " has been fixed.
1313
- `F23048` - This issue "When change style of group at runtime the same is applied to its child too " has been fixed.
14+
- `317728` - This issue "Line routing is not working if the connection end point of the connector has two or more nodes " has been fixed.
1415

1516
## 18.4.47 (2021-03-09)
1617

controls/diagrams/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@syncfusion/ej2-diagrams",
3-
"version": "18.4.47",
3+
"version": "18.4.48",
44
"description": "Feature-rich diagram control to create diagrams like flow charts, organizational charts, mind maps, and BPMN diagrams. Its rich feature set includes built-in shapes, editing, serializing, exporting, printing, overview, data binding, and automatic layouts.",
55
"author": "Syncfusion Inc.",
66
"license": "SEE LICENSE IN license",

0 commit comments

Comments
 (0)