Skip to content

Commit bee9bfa

Browse files
committed
Fix extracting of message from ->trans() method with named params
1 parent 34b6518 commit bee9bfa

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Extractor/Visitor/TransMethodVisitor.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function leaveNode(Node $node): ?Node
4444
if ('trans' === $name || 't' === $name) {
4545
$firstNamedArgumentIndex = $this->nodeFirstNamedArgumentIndex($node);
4646

47-
if (!$messages = $this->getStringArguments($node, 0 < $firstNamedArgumentIndex ? 0 : 'message')) {
47+
if (!$messages = $this->getStringArguments($node, 0 < $firstNamedArgumentIndex ? 0 : 'id')) {
4848
return null;
4949
}
5050

Tests/Fixtures/extractor-ast/translation.html.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,14 @@
4646

4747
<?php echo $view['translator']->trans('default domain', [], null); ?>
4848

49-
<?php echo $view['translator']->trans(message: 'ordered-named-arguments-in-trans-method', parameters: [], domain: 'not_messages'); ?>
50-
<?php echo $view['translator']->trans(domain: 'not_messages', message: 'disordered-named-arguments-in-trans-method', parameters: []); ?>
49+
<?php echo $view['translator']->trans(id: 'ordered-named-arguments-in-trans-method', parameters: [], domain: 'not_messages'); ?>
50+
<?php echo $view['translator']->trans(domain: 'not_messages', id: 'disordered-named-arguments-in-trans-method', parameters: []); ?>
5151

5252
<?php echo $view['translator']->trans($key = 'variable-assignation-inlined-in-trans-method-call1', $parameters = [], $domain = 'not_messages'); ?>
5353
<?php echo $view['translator']->trans('variable-assignation-inlined-in-trans-method-call2', $parameters = [], $domain = 'not_messages'); ?>
5454
<?php echo $view['translator']->trans('variable-assignation-inlined-in-trans-method-call3', [], $domain = 'not_messages'); ?>
5555

56-
<?php echo $view['translator']->trans(domain: $domain = 'not_messages', message: $key = 'variable-assignation-inlined-with-named-arguments-in-trans-method', parameters: $parameters = []); ?>
56+
<?php echo $view['translator']->trans(domain: $domain = 'not_messages', id: $key = 'variable-assignation-inlined-with-named-arguments-in-trans-method', parameters: $parameters = []); ?>
5757

5858
<?php echo $view['translator']->trans('mix-named-arguments', parameters: ['foo' => 'bar']); ?>
5959
<?php echo $view['translator']->trans('mix-named-arguments-locale', parameters: ['foo' => 'bar'], locale: 'de'); ?>

0 commit comments

Comments
 (0)